Commit r281773 is not right, it is necessary to check the return of ixgbe_rxeof, pretty much similar as the implementation of ixv_handle_que() on if_ixv.c
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
I'm hesitant to approve this because the if (more) {...} section was removed in r251964. I'd want a reason for putting it back in the driver.
Comment Actions
We removed these additional task creations with the intent purpose of
reducing lock contention for a customer as I recall, so unless you have a
good reason to add it back I would oppose doing so.
Comment Actions
Actually I was tracing the code and verified that ixgbe_rxeof() is called at ixgbe_legacy_irq() that does check if there is more package to be processed as well as in ixgbe_msix_que(). Also in other files it is called in the same way as example in if_ixv.c. I wasn't aware of your internal request.
So, I have no good reason to bring it back then.
Thanks and all the best.