Page MenuHomeFreeBSD

Fix properly commit r281773.
AbandonedPublic

Authored by araujo on Apr 22 2015, 9:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 27 2017, 7:31 PM
Unknown Object (File)
Feb 12 2017, 12:34 AM
Unknown Object (File)
Dec 25 2016, 11:52 PM
Unknown Object (File)
Dec 23 2016, 7:45 AM
Unknown Object (File)
Dec 15 2016, 5:51 AM
Unknown Object (File)
Jun 30 2016, 8:47 PM
Unknown Object (File)
Jun 29 2016, 3:51 PM
Unknown Object (File)
Mar 8 2016, 1:27 PM
Subscribers

Details

Reviewers
jfv
erj
Summary

Commit r281773 is not right, it is necessary to check the return of ixgbe_rxeof, pretty much similar as the implementation of ixv_handle_que() on if_ixv.c

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

araujo retitled this revision from to Fix properly commit r281773..
araujo updated this object.
araujo edited the test plan for this revision. (Show Details)
araujo added a reviewer: erj.

erj@ can you review this patch? It looks pretty much correct.

I'm hesitant to approve this because the if (more) {...} section was removed in r251964. I'd want a reason for putting it back in the driver.

@jfv says that section was taken out to reduce lock contention.

We removed these additional task creations with the intent purpose of
reducing lock contention for a customer as I recall, so unless you have a
good reason to add it back I would oppose doing so.

Actually I was tracing the code and verified that ixgbe_rxeof() is called at ixgbe_legacy_irq() that does check if there is more package to be processed as well as in ixgbe_msix_que(). Also in other files it is called in the same way as example in if_ixv.c. I wasn't aware of your internal request.

So, I have no good reason to bring it back then.

Thanks and all the best.