e1000: remove unused ifp backpointer
ClosedPublic
Actions

Authored by vmaffione on Nov 28 2021, 10:18 PM.

Details

Reviewers

gallatin
markj
kbowling
erj

Commits

rGd10ea34d1128: e1000: remove unused ifp backpointer
rGa00d9c7f8cd9: e1000: remove unused ifp backpointer
rGd91559564dc6: e1000: remove unused ifp backpointer

Summary

The ifp (struct ifnet) backpointer in the e1000 private ifnet
data is not used anymore since the iflib transition.
Remove it so that developers are not tempted to use it and
get a NULL pointer dereference.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vmaffione created this revision.Nov 28 2021, 10:18 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 28 2021, 10:18 PM

vmaffione requested review of this revision.Nov 28 2021, 10:18 PM

markj accepted this revision.Nov 29 2021, 4:00 PM

This revision is now accepted and ready to land.Nov 29 2021, 4:00 PM

kbowling accepted this revision.Dec 1 2021, 5:24 PM

erj accepted this revision.Dec 1 2021, 5:27 PM

Closed by commit rGd91559564dc6: e1000: remove unused ifp backpointer (authored by vmaffione). · Explain WhyDec 1 2021, 9:09 PM

This revision was automatically updated to reflect the committed changes.

vmaffione added a commit: rGd91559564dc6: e1000: remove unused ifp backpointer.

vmaffione added a commit: rGa00d9c7f8cd9: e1000: remove unused ifp backpointer.Dec 18 2021, 11:59 AM

vmaffione added a commit: rGd10ea34d1128: e1000: remove unused ifp backpointer.Dec 22 2021, 1:45 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

e1000/

if_em.h

1 line

Diff 99331

View Options

e1000: remove unused ifp backpointerClosedPublicActions