Page MenuHomeFreeBSD

e1000: print EEPROM/NVM/OROM versions
ClosedPublic

Authored by kbowling on Oct 6 2021, 12:45 AM.

Details

Summary

Similar to ixgbe, this is useful for diagnosing problems. In particular, the errata sheets identify the EEPROM version for many fixes.

Test Plan

82579LM:
em0: EEPROM V0.13-4

i219 (2) SPT:
em0: EEPROM V0.8-3

i210:
igb0: EEPROM V3.25-0 eTrack 0x800005cc

i350:
igb0: EEPROM V1.63-0 eTrack 0x800009fb

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

gallatin added inline comments.
sys/dev/e1000/if_em.c
4500

If it was me, I'd probably print something like "NVM version unknown"

This revision is now accepted and ready to land.Oct 6 2021, 12:53 PM
kbowling edited the test plan for this revision. (Show Details)
This revision now requires review to proceed.Oct 6 2021, 6:20 PM
kbowling edited the test plan for this revision. (Show Details)
sys/dev/e1000/if_em.c
4521

This will be committed as a separate bug fix, it prevents a KASSERT deep in the shared code

@gallatin can you have another look? The locking model on the e1000 is tricky due to the HW so I stashed the info on attach. There's a separate KASSERT fix for em_print_nvm_info for review as well.

This revision is now accepted and ready to land.Oct 6 2021, 10:58 PM