if_ix: Reset on an ECC error
ClosedPublic
Actions

Authored by nc on Jun 22 2022, 2:21 AM.

Details

Reviewers

grehan
kbowling
jhb

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rGd0303ad18ae9: if_ix: Reset on an ECC error
rG7a8188739a99: if_ix: Reset on an ECC error
rG4f1d91e413d7: if_ix: Reset on an ECC error

Summary

This mirrors the Linux behavior as seen in the kernel commit d773ce2.

Test Plan

On some systems, I get this error with an ixgbe-based NIC, namely
the AMD Ryzen-based HP Omen 30L. We shouldn't be failing as Linux isn't either.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nc created this revision.Jun 22 2022, 2:21 AM

Herald added subscribers: ae, imp. · View Herald TranscriptJun 22 2022, 2:21 AM

nc requested review of this revision.Jun 22 2022, 2:21 AM

Harbormaster completed remote builds in B46056: Diff 107227.Jun 22 2022, 2:21 AM

kbowling accepted this revision.Jun 22 2022, 3:12 AM

This revision is now accepted and ready to land.Jun 22 2022, 3:12 AM

Closed by commit rG4f1d91e413d7: if_ix: Reset on an ECC error (authored by nc). · Explain WhyJun 22 2022, 3:23 AM

This revision was automatically updated to reflect the committed changes.

nc added a commit: rG4f1d91e413d7: if_ix: Reset on an ECC error.

Owners added a reviewer: Restricted Owners Package.Jun 22 2022, 3:23 AM

nc added a commit: rG7a8188739a99: if_ix: Reset on an ECC error.Jun 29 2022, 5:08 PM

nc added a commit: rGd0303ad18ae9: if_ix: Reset on an ECC error.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ixgbe/

if_ix.c

4 lines

Diff 107228

View Options

if_ix: Reset on an ECC errorClosedPublicActions