cramerj_intel.com (Jeb Cramer)
User

Projects

User Details

User Since
Nov 30 2015, 10:23 PM (137 w, 1 d)

Recent Activity

Sep 29 2017

cramerj_intel.com updated the diff for D11727: ixgbe(4): Update HEAD to use iflib.
  • Allow for VLAN filtering in VFs by re-adding capability flag.
  • Add function prototype for ixgbe_tx_ctx_setup() to fix compilation error.
Sep 29 2017, 5:38 PM

Sep 7 2017

cramerj_intel.com added inline comments to D12235: iflib rollup patch..
Sep 7 2017, 3:24 PM

Aug 31 2017

cramerj_intel.com updated the diff for D11727: ixgbe(4): Update HEAD to use iflib.

Rebase due to out-of-band commit to HEAD.

Aug 31 2017, 12:54 AM
cramerj_intel.com updated the diff for D11727: ixgbe(4): Update HEAD to use iflib.
  • Moved ixgbe_if_init() declaration into ixgbe_sriov.h since both if_ix.c and if_sriov.c include that header file and it's no longer declared for the VF driver that can't link to it anyway.
Aug 31 2017, 12:19 AM

Aug 29 2017

cramerj_intel.com updated the diff for D11727: ixgbe(4): Update HEAD to use iflib.
  • Fixed dmac sysctl reporting negative value due to incompatible type.
  • Adjusted other sysctl functions to use the correct handler function.
Aug 29 2017, 6:54 PM
cramerj_intel.com updated the diff for D11727: ixgbe(4): Update HEAD to use iflib.
  • Re-commit patches on top of commit from review D11712
  • Move the stats updates to the admin update task.
  • Removed setup_optics since it isn't useful code.
  • Moved check for link from the timer context to the admin task.
  • Changed iflib member for setting number of Tx/Rx queues in PF driver.
  • Incorporated more of sbruno's suggestions for D11727 review.
  • Removed SR-IOV code from the VF driver.
Aug 29 2017, 5:23 PM

Aug 17 2017

cramerj_intel.com added a comment to D12040: direct vlan handling in ixgbe.

Perhaps a rename of the new files to reflect the technology/enhancement you are proposing? Most people won't associate Yandex with VLANs. Regardless, to really benefit FreeBSD in general, you should probably include patches to other drivers as well, since VLANs are not specific to Intel devices.

Aug 17 2017, 7:12 PM

Jul 31 2017

cramerj_intel.com added a comment to D11727: ixgbe(4): Update HEAD to use iflib.

Regarding the redefinition of CSUM_TCP/etc., I see what Matt was doing in terms of having these defines mean something more than just a renaming of some other macro. And I like the intention of this; it mimics what the CSUM_TSO macro does. However, I removed those undef/defines from ix_txrx.c in favor of explicitly using, for example, "(CSUM_IP_TCP | CSUM_IP6_TCP)". Those lines still fit in 80 columns. :)

Jul 31 2017, 9:36 PM
cramerj_intel.com updated the diff for D11727: ixgbe(4): Update HEAD to use iflib.
  • Incorporated more of sbruno's suggestions for D11727 review.
Jul 31 2017, 9:27 PM
cramerj_intel.com added a comment to D11727: ixgbe(4): Update HEAD to use iflib.

I might be missing something, but that was what I modified before our Thursday morning meeting. It should be using the isc_n[rt]xqsets_max members now.

Jul 31 2017, 9:02 PM

Jul 27 2017

cramerj_intel.com updated the diff for D11727: ixgbe(4): Update HEAD to use iflib.
  • Changed iflib member for setting number of Tx/Rx queues in PF driver.
Jul 27 2017, 2:24 PM
cramerj_intel.com added inline comments to D11727: ixgbe(4): Update HEAD to use iflib.
Jul 27 2017, 4:37 AM
cramerj_intel.com updated the diff for D11727: ixgbe(4): Update HEAD to use iflib.

From sbruno's comments:

  • Moved check for link from the timer context to the admin task.
  • Fixed resource ID setting for the admin task.
  • Adjusted tso_tx to be u64 type.
Jul 27 2017, 4:24 AM

Jul 25 2017

cramerj_intel.com abandoned D11058: ixgbe(4): Update 11-STABLE to 3.2.12-k.
Jul 25 2017, 9:32 PM
cramerj_intel.com abandoned D5213: convert ixgbe to iflib.
Jul 25 2017, 9:31 PM
cramerj_intel.com commandeered D5213: convert ixgbe to iflib.
Jul 25 2017, 9:30 PM
cramerj_intel.com added a comment to D11727: ixgbe(4): Update HEAD to use iflib.

Thanks. Review updated.

Jul 25 2017, 9:10 PM
cramerj_intel.com updated the diff for D11727: ixgbe(4): Update HEAD to use iflib.
  • Removed setup_optics since it isn't useful code.
  • Added use for get_advertise.
  • Changed module dependency from netmap to iflib.
Jul 25 2017, 9:09 PM
cramerj_intel.com updated the diff for D11727: ixgbe(4): Update HEAD to use iflib.
  • Move the stats updates to the admin update task.
Jul 25 2017, 8:44 PM
cramerj_intel.com updated the diff for D11727: ixgbe(4): Update HEAD to use iflib.

A rebase on top of D11712.

Jul 25 2017, 4:47 PM
cramerj_intel.com updated the diff for D11727: ixgbe(4): Update HEAD to use iflib.
  • Added ifdi_if.h to the SRCs flag for compilation.
Jul 25 2017, 2:45 PM
cramerj_intel.com created D11727: ixgbe(4): Update HEAD to use iflib.
Jul 25 2017, 8:06 AM

Jul 11 2017

cramerj_intel.com added inline comments to D11476: iflib - try m_defrag when m_collapse fails.
Jul 11 2017, 10:38 PM

Jul 10 2017

cramerj_intel.com added a comment to D11232: ixgbe(4): Update HEAD (p3) to 3.2.12-k.

Committed in r320688

Jul 10 2017, 4:39 PM

Jul 8 2017

cramerj_intel.com closed D11232: ixgbe(4): Update HEAD (p3) to 3.2.12-k.
Jul 8 2017, 1:43 AM

Jul 7 2017

cramerj_intel.com accepted D11232: ixgbe(4): Update HEAD (p3) to 3.2.12-k.
Jul 7 2017, 8:36 PM

Jun 28 2017

cramerj_intel.com updated the diff for D11232: ixgbe(4): Update HEAD (p3) to 3.2.12-k.
  • Fixed unresolved symbol issue with ixv.
Jun 28 2017, 1:03 AM

Jun 27 2017

cramerj_intel.com abandoned D10293: ixgbe(4): Update HEAD (p2) to 3.2.12-k.

Another review will be created shortly to fit on top of D11232.

Jun 27 2017, 8:39 PM

Jun 23 2017

cramerj_intel.com updated the diff for D11232: ixgbe(4): Update HEAD (p3) to 3.2.12-k.
  • Fixed a load error when trying to load ixv dynamically.
Jun 23 2017, 5:39 PM

Jun 21 2017

cramerj_intel.com updated the diff for D11232: ixgbe(4): Update HEAD (p3) to 3.2.12-k.
  • Fixed version error.
Jun 21 2017, 4:47 PM

Jun 20 2017

cramerj_intel.com updated the diff for D11232: ixgbe(4): Update HEAD (p3) to 3.2.12-k.
  • Removed "Frame Limit" flag as it seems unnecessary.
Jun 20 2017, 9:39 PM
cramerj_intel.com updated the diff for D11232: ixgbe(4): Update HEAD (p3) to 3.2.12-k.
  • Fixed compilation error with ixv when compiled dynamically.
Jun 20 2017, 1:18 AM

Jun 16 2017

cramerj_intel.com updated the diff for D11232: ixgbe(4): Update HEAD (p3) to 3.2.12-k.
  • Fixed compilation issue with unused variables.
Jun 16 2017, 4:07 PM
cramerj_intel.com created D11232: ixgbe(4): Update HEAD (p3) to 3.2.12-k.
Jun 16 2017, 1:31 AM

Jun 14 2017

cramerj_intel.com updated the diff for D10293: ixgbe(4): Update HEAD (p2) to 3.2.12-k.
  • Fixed updating OS stats issue in VF driver.
Jun 14 2017, 11:57 PM
cramerj_intel.com updated the diff for D11058: ixgbe(4): Update 11-STABLE to 3.2.12-k.
  • Fixed stat updating issue for VF driver.
Jun 14 2017, 11:33 PM

Jun 7 2017

cramerj_intel.com updated the diff for D11058: ixgbe(4): Update 11-STABLE to 3.2.12-k.
  • Removed double definition of two functions.
Jun 7 2017, 8:31 PM

Jun 6 2017

cramerj_intel.com updated the diff for D11058: ixgbe(4): Update 11-STABLE to 3.2.12-k.
  • Added netmap file to makefiles.
Jun 6 2017, 11:23 PM

Jun 5 2017

cramerj_intel.com updated the diff for D10293: ixgbe(4): Update HEAD (p2) to 3.2.12-k.
  • Removed code that is already performed in the iflib layer. This should help Tx function in the VF driver.
Jun 5 2017, 9:45 PM
cramerj_intel.com updated the diff for D10293: ixgbe(4): Update HEAD (p2) to 3.2.12-k.
  • Fixed some panics when using VF driver. The VF driver still doesn't work, however.
Jun 5 2017, 9:13 PM
cramerj_intel.com updated the diff for D11058: ixgbe(4): Update 11-STABLE to 3.2.12-k.
  • Backed out M_IXGBE memory type for queue allocation. Using DEVBUF.
Jun 5 2017, 8:43 PM
cramerj_intel.com updated the diff for D11058: ixgbe(4): Update 11-STABLE to 3.2.12-k.
  • Fixed compilation error for ixgbe_vf.c
Jun 5 2017, 7:40 PM
cramerj_intel.com updated the diff for D11058: ixgbe(4): Update 11-STABLE to 3.2.12-k.
  • Fixed some compilation errors for if_sriov.c.
Jun 5 2017, 6:58 PM
cramerj_intel.com updated the diff for D11058: ixgbe(4): Update 11-STABLE to 3.2.12-k.
  • Added files to Makefile for building.
Jun 5 2017, 5:33 PM
cramerj_intel.com updated the diff for D11058: ixgbe(4): Update 11-STABLE to 3.2.12-k.
  • Add files to sys/conf/files list to build ix/ixv.
Jun 5 2017, 5:13 PM
cramerj_intel.com created D11058: ixgbe(4): Update 11-STABLE to 3.2.12-k.
Jun 5 2017, 4:57 PM

May 24 2017

cramerj_intel.com updated the diff for D10293: ixgbe(4): Update HEAD (p2) to 3.2.12-k.
  • Applied same ring accounting bug fix to ixv as was committed to the PF driver in previous commit.
  • Modified ixv to indicate that we don't support full frame sizes when VLANs are enabled if the hardware is 82599 and jumbo frames is disabled.
May 24 2017, 3:33 PM

May 6 2017

cramerj_intel.com updated the diff for D10293: ixgbe(4): Update HEAD (p2) to 3.2.12-k.
  • Fixed Report Status accounting not being reset when interface down/up'd.
May 6 2017, 6:27 PM

Apr 21 2017

cramerj_intel.com updated the diff for D10293: ixgbe(4): Update HEAD (p2) to 3.2.12-k.
  • Building the drivers fails because of the malloc-type change I performed in a previous commit. Reverting that change.
Apr 21 2017, 8:21 PM

Apr 13 2017

cramerj_intel.com updated the diff for D10293: ixgbe(4): Update HEAD (p2) to 3.2.12-k.
  • Fixed VF driver.
  • Another attempt at fixing 2.5G reporting.
Apr 13 2017, 4:12 AM

Apr 11 2017

cramerj_intel.com updated the diff for D10293: ixgbe(4): Update HEAD (p2) to 3.2.12-k.
  • Updated interrupt setup/servicing/detection to match OOT. This fixes the issue of the interface not coming back up after unplugging/re-plugging in the module/cable.
Apr 11 2017, 1:17 AM

Apr 10 2017

cramerj_intel.com updated the diff for D10293: ixgbe(4): Update HEAD (p2) to 3.2.12-k.
  • Fixed reporting of 2.5G speeds
Apr 10 2017, 9:27 PM
cramerj_intel.com abandoned D9851: ixgbe(4): Update HEAD to 3.2.12-k.

Replaced with D10293

Apr 10 2017, 8:54 PM
cramerj_intel.com updated the diff for D10293: ixgbe(4): Update HEAD (p2) to 3.2.12-k.
  • Moved code around to match if_ix.c and/or the OOT driver
  • Wrapped KTR code with ifdef for those using GENERIC-NODEBUG
Apr 10 2017, 5:24 PM

Apr 9 2017

cramerj_intel.com updated the diff for D10293: ixgbe(4): Update HEAD (p2) to 3.2.12-k.
  • Fixed legacy interrupt insta-panic
  • Possibly fixed flow control functionality
  • Bumped default ring sizes to previous default (2K)
  • Fixed overtemp warning for appropriate PHYs
  • VF driver has evolved, but not quite stable yet
  • Legacy interrupt passes traffic, but a "lock order reversal" has been sighted. iflib ctx lock.
Apr 9 2017, 9:07 AM
cramerj_intel.com retitled D10293: ixgbe(4): Update HEAD (p2) to 3.2.12-k from Update HEAD (p2) to 3.2.12-k to ixgbe(4): Update HEAD (p2) to 3.2.12-k.
Apr 9 2017, 9:03 AM

Apr 6 2017

cramerj_intel.com created D10293: ixgbe(4): Update HEAD (p2) to 3.2.12-k.
Apr 6 2017, 4:58 AM

Mar 17 2017

cramerj_intel.com updated the diff for D9851: ixgbe(4): Update HEAD to 3.2.12-k.
  • Fixed compilation issue when PCIOV is not defined.
  • Fixed issue with setting advertise speed correctly for DNV hardware.
  • Applied some changes based off of smh's style suggestions.
Mar 17 2017, 6:58 PM

Mar 13 2017

cramerj_intel.com added inline comments to D5213: convert ixgbe to iflib.
Mar 13 2017, 4:15 PM

Mar 9 2017

cramerj_intel.com added a comment to D9851: ixgbe(4): Update HEAD to 3.2.12-k.

Thanks for the feedback. I'll look into these suggestions.

Mar 9 2017, 8:18 PM

Mar 2 2017

cramerj_intel.com updated D9851: ixgbe(4): Update HEAD to 3.2.12-k.
Mar 2 2017, 3:11 PM
cramerj_intel.com added a dependency for D9851: ixgbe(4): Update HEAD to 3.2.12-k: D5213: convert ixgbe to iflib.
Mar 2 2017, 1:51 AM
cramerj_intel.com added a dependent revision for D5213: convert ixgbe to iflib: D9851: ixgbe(4): Update HEAD to 3.2.12-k.
Mar 2 2017, 1:51 AM
cramerj_intel.com retitled D9851: ixgbe(4): Update HEAD to 3.2.12-k from to ixgbe(4): Update HEAD to 3.2.12-k.
Mar 2 2017, 1:33 AM

Jan 24 2017

cramerj_intel.com updated the diff for D9310: ixgbe(4): Update to 3.2.11-k.
  • Fixed compilation error for the VF driver.
Jan 24 2017, 5:45 PM · Intel Networking
cramerj_intel.com retitled D9310: ixgbe(4): Update to 3.2.11-k from to ixgbe(4): Update to 3.2.11-k.
Jan 24 2017, 1:53 AM · Intel Networking

Oct 5 2016

cramerj_intel.com abandoned D6943: Use ixgbe-specific malloc type.

Abandoning for now. Will resubmit this patch along with many more changes in a different review.

Oct 5 2016, 3:58 PM
cramerj_intel.com abandoned D6926: ix(4), Whitespace changes.

Abandoning for now. Will resubmit this patch along with many more changes in a different review.

Oct 5 2016, 3:57 PM
cramerj_intel.com abandoned D6944: Remove unnecessary variable for NVM checksum.

Abandoning for now. Will resubmit this patch along with many more changes in a different review.

Oct 5 2016, 3:56 PM
cramerj_intel.com added a comment to D6944: Remove unnecessary variable for NVM checksum.

I'm going to abandon/close it today after I ask Eric how to do that. :) This patch will show up again soon, but along with the rest of the changes I'm adding.

Oct 5 2016, 3:53 PM

Jun 28 2016

cramerj_intel.com added a comment to D6944: Remove unnecessary variable for NVM checksum.

The csum variable holds the checksum, yes. But nothing in attach() uses it afterwards. We only care about the return value of the function. I think the csum variable was added originally because ixgbe_validate_eeprom_checksum(), at that time, required a non-NULL input parameter...maybe? But then over time it was enhanced to allow a NULL parameter for drivers that didn't care about the csum value itself, but just the pass/fail return value of the function. In other words, ixgbe_validate_eeprom_checksum() will only populate "csum" if it's non-NULL. Grep for "checksum_val" to see what I mean.

Jun 28 2016, 6:09 PM

Jun 23 2016

cramerj_intel.com added a dependency for D6944: Remove unnecessary variable for NVM checksum: D6926: ix(4), Whitespace changes.
Jun 23 2016, 6:11 PM
cramerj_intel.com added a dependent revision for D6926: ix(4), Whitespace changes: D6944: Remove unnecessary variable for NVM checksum.
Jun 23 2016, 6:11 PM
cramerj_intel.com retitled D6944: Remove unnecessary variable for NVM checksum from to Remove unnecessary variable for NVM checksum.
Jun 23 2016, 6:11 PM
cramerj_intel.com added a dependency for D6943: Use ixgbe-specific malloc type: D6926: ix(4), Whitespace changes.
Jun 23 2016, 5:46 PM
cramerj_intel.com added a dependent revision for D6926: ix(4), Whitespace changes: D6943: Use ixgbe-specific malloc type.
Jun 23 2016, 5:46 PM
cramerj_intel.com retitled D6943: Use ixgbe-specific malloc type from to Use ixgbe-specific malloc type.
Jun 23 2016, 5:45 PM

Jun 22 2016

cramerj_intel.com updated the diff for D6926: ix(4), Whitespace changes.
  • Fixed compilation issue.
Jun 22 2016, 9:48 PM
cramerj_intel.com updated D6926: ix(4), Whitespace changes.
Jun 22 2016, 9:28 PM
cramerj_intel.com retitled D6926: ix(4), Whitespace changes from to ix(4), Whitespace changes.
Jun 22 2016, 9:23 PM

Apr 18 2016

cramerj_intel.com added a comment to D4295: Add driver backpressure.

Does ixgbe compile with the first parenthesis missing?

Apr 18 2016, 5:53 PM · transport
cramerj_intel.com added a comment to D5918: Avoid underflow during calculation of space avail for nsegs.

Looks good to me.

Apr 18 2016, 5:20 PM