Page MenuHomeFreeBSD
Differential D6926

ix(4), Whitespace changes
AbandonedPublic
Actions

Authored by cramerj_intel.com on Jun 22 2016, 9:23 PM.
Tags
None
Referenced Files
F81670222: D6926.id.diff
Fri, Apr 19, 5:29 PM
Unknown Object (File)
Feb 1 2024, 6:58 PM
Unknown Object (File)
Dec 13 2023, 10:50 PM
Unknown Object (File)
Dec 11 2023, 11:05 PM
Unknown Object (File)
Dec 7 2023, 9:59 AM
Unknown Object (File)
Dec 5 2023, 10:03 AM
Unknown Object (File)
Nov 28 2023, 3:33 PM
Unknown Object (File)
Nov 28 2023, 9:46 AM
View All 42 Files
Subscribers
imp

Details

Reviewers
sbruno
Group Reviewers
Intel Networking
Summary

Copyright changes, function headers, string concatenations. Possible contention...strings exceed 80 character limit, but no longer breaks grep.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4306
Build 4350: arc lint + arc unit

Event Timeline

cramerj_intel.com updated this revision to Diff 17775.Jun 22 2016, 9:23 PM
cramerj_intel.com retitled this revision from to ix(4), Whitespace changes.
cramerj_intel.com updated this object.
cramerj_intel.com edited the test plan for this revision. (Show Details)
cramerj_intel.com added a reviewer: Intel Networking.
cramerj_intel.com set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a reviewer: sbruno. · View Herald TranscriptJun 22 2016, 9:23 PM
Herald added a subscriber: imp. · View Herald Transcript
cramerj_intel.com updated this object.Jun 22 2016, 9:28 PM
cramerj_intel.com edited edge metadata.
cramerj_intel.com updated this revision to Diff 17778.Jun 22 2016, 9:48 PM
  • Fixed compilation issue.
Herald edited edge metadata. · View Herald TranscriptJun 22 2016, 9:48 PM
cramerj_intel.com added a child revision: D6943: Use ixgbe-specific malloc type.Jun 23 2016, 5:46 PM
cramerj_intel.com added a child revision: D6944: Remove unnecessary variable for NVM checksum.Jun 23 2016, 6:11 PM
sbruno accepted this revision.Jun 28 2016, 4:24 PM
sbruno edited edge metadata.

shipit

This revision is now accepted and ready to land.Jun 28 2016, 4:24 PM
cramerj_intel.com abandoned this revision.Oct 5 2016, 3:57 PM

Abandoning for now. Will resubmit this patch along with many more changes in a different review.

Revision Contents
Changeset List

Diff 17778

View Options

sys/dev/ixgbe/if_ix.c

Loading...
View Options

sys/dev/ixgbe/ix_txrx.c

Loading...
View Options

sys/dev/ixgbe/ixgbe.h

Loading...
View Options

sys/dev/ixgbe/ixgbe_82598.h

Loading...
View Options

sys/dev/ixgbe/ixgbe_82598.c

Loading...
View Options

sys/dev/ixgbe/ixgbe_82599.h

Loading...
View Options

sys/dev/ixgbe/ixgbe_82599.c

Loading...
View Options

sys/dev/ixgbe/ixgbe_api.h

Loading...
View Options

sys/dev/ixgbe/ixgbe_api.c

Loading...
View Options

sys/dev/ixgbe/ixgbe_common.h

Loading...
View Options

sys/dev/ixgbe/ixgbe_common.c

Loading...
View Options

sys/dev/ixgbe/ixgbe_dcb.h

Loading...
View Options

sys/dev/ixgbe/ixgbe_dcb.c

Loading...
View Options

sys/dev/ixgbe/ixgbe_dcb_82598.h

Loading...
View Options

sys/dev/ixgbe/ixgbe_dcb_82598.c

Loading...
View Options

sys/dev/ixgbe/ixgbe_dcb_82599.h

Loading...
View Options

sys/dev/ixgbe/ixgbe_dcb_82599.c

Loading...
View Options

sys/dev/ixgbe/ixgbe_mbx.h

Loading...
View Options

sys/dev/ixgbe/ixgbe_mbx.c

Loading...
View Options

sys/dev/ixgbe/ixgbe_osdep.h

Loading...
View Options

sys/dev/ixgbe/ixgbe_osdep.c

Loading...
View Options

sys/dev/ixgbe/ixgbe_phy.h

Loading...
View Options

sys/dev/ixgbe/ixgbe_phy.c

Loading...
View Options

sys/dev/ixgbe/ixgbe_type.h

Loading...
View Options

sys/dev/ixgbe/ixgbe_x540.h

Loading...
View Options

sys/dev/ixgbe/ixgbe_x540.c

Loading...
View Options

sys/dev/ixgbe/ixgbe_x550.h

Loading...
View Options

sys/dev/ixgbe/ixgbe_x550.c

Loading...