ixgbe(4): Update HEAD (p3) to 3.2.12-k

Authored by cramerj_intel.com on Jun 16 2017, 1:31 AM.



Update to ixgbe including:

  • Support for X550EM devices.
  • Support for Bypass adapters.
  • Flow Director code moved to separate files
  • SR-IOV code moved to separate files
  • Netmap code moved to separate files

This does NOT contain iflib support. Review D10293 (with iflib support) will be abandoned and a new review will be created to add iflib support.

Test Plan

Work-in-progress. Respectfully request waiting for Jeff's team to perform a validation pass before committing.

Diff Detail

Lint OK
No Unit Test Coverage
Build Status
Buildable 10159
Build 10582: arc lint + arc unit
  • Fixed compilation issue with unused variables.
  • Fixed compilation error with ixv when compiled dynamically.
  • Removed "Frame Limit" flag as it seems unnecessary.
  • Fixed version error.
  • Fixed a load error when trying to load ixv dynamically.
  • Fixed unresolved symbol issue with ixv.
This revision is now accepted and ready to land.Jun 29 2017, 11:50 PM
jeffrey.e.pieper_intel.com requested changes to this revision.Jul 1 2017, 2:54 AM

We need to hold off on committing this. We are investigating some issues that were discovered today.

This revision now requires changes to proceed.Jul 1 2017, 2:54 AM
erj accepted this revision.Jul 5 2017, 5:28 PM
cramerj_intel.com accepted this revision.Jul 7 2017, 8:36 PM
This revision is now accepted and ready to land.Jul 7 2017, 11:15 PM

In the future when you find yourselves implementing synchronization primitives like swfw_sync or your hand rolled locks in if_bypass.c please make sure you get the attention and sign off from @markj, @jhb, or myself.


This lock needs to be replaced.

kmacy added a reviewer: shurd.Aug 23 2017, 6:33 AM
kmacy added a comment.EditedAug 23 2017, 6:35 AM

Also, can we stop massively refactoring the drivers until after the iflib version goes in to HEAD? And in general, there's a lot of non-productive function shuffling that goes on in Intel drivers that makes it a lot more work for downstream users maintaining their own branches.

kmacy added inline comments.Aug 25 2017, 10:55 PM

Has this code ever been tested with IXGBE_FDIR enabled? This leads to duplicate symbols.