smh (Steven Hartland)
User

Projects

User Details

User Since
Aug 3 2014, 6:44 PM (193 w, 5 d)

Recent Activity

Tue, Apr 17

smh added a comment to D14985: ixl(4): Update to 1.9.8-k.

Is there anything happening with this as head is still 1.7.12-k which is very far behind the latest intel download which is 1.9.7?

Tue, Apr 17, 9:54 AM

Mon, Apr 16

smh accepted D15097: mpr: Fix deadlock when handling panic.
Mon, Apr 16, 3:57 PM

Mon, Apr 9

smh committed rS332318: MFC r327559:.
MFC r327559:
Mon, Apr 9, 8:25 AM

Fri, Apr 6

smh accepted D14972: allow ZFS pool to have temporary name for duration of current import.
Fri, Apr 6, 4:14 PM

Thu, Apr 5

smh added inline comments to D14972: allow ZFS pool to have temporary name for duration of current import.
Thu, Apr 5, 9:04 PM
smh requested changes to D14972: allow ZFS pool to have temporary name for duration of current import.
Thu, Apr 5, 9:01 PM

Sat, Mar 31

smh committed rS331851: MFC r320138:.
MFC r320138:
Sat, Mar 31, 7:22 PM
smh committed rS331850: MFC r328321:.
MFC r328321:
Sat, Mar 31, 7:19 PM
smh committed rS331849: MFC r330951:.
MFC r330951:
Sat, Mar 31, 7:18 PM
smh committed rS331848: MFC r330950:.
MFC r330950:
Sat, Mar 31, 7:16 PM

Mar 14 2018

smh committed rS330951: Fix mps deadlock when handling panic.
Fix mps deadlock when handling panic
Mar 14 2018, 9:32 PM
smh closed D12776: Fix mps deadlock when handling panic.
Mar 14 2018, 9:32 PM
smh closed D14695: Prevent ZFS TRIM breaking VTOC8 partitions.

Closed by https://svnweb.freebsd.org/changeset/base/330950

Mar 14 2018, 9:23 PM
smh committed rS330950: Prevent ZFS TRIM breaking VTOC8 partitions.
Prevent ZFS TRIM breaking VTOC8 partitions
Mar 14 2018, 9:21 PM
smh added a comment to D14695: Prevent ZFS TRIM breaking VTOC8 partitions.

Its only a problem for devices that report they support TRIM so it wouldn't impact HDD's but would effect SSD's or MD devices.

Mar 14 2018, 9:12 PM
smh added a comment to D12776: Fix mps deadlock when handling panic.

Sorry guys this dropped off my radar, only just spotted your updates when reviewing other changes.

Mar 14 2018, 9:06 PM
smh added inline comments to D12776: Fix mps deadlock when handling panic.
Mar 14 2018, 9:04 PM
smh updated the diff for D12776: Fix mps deadlock when handling panic.

Added howto param name to prototypes.

Mar 14 2018, 9:03 PM
smh updated the diff for D14695: Prevent ZFS TRIM breaking VTOC8 partitions.

Correct size argument as zio_trim is offset + size not start + end.

Mar 14 2018, 8:34 PM
smh retitled D14695: Prevent ZFS TRIM breaking VTOC8 partitions from Prevent ZFS TRIM breakng VTOC8 partitions to Prevent ZFS TRIM breaking VTOC8 partitions.
Mar 14 2018, 5:41 PM
smh created D14695: Prevent ZFS TRIM breaking VTOC8 partitions.
Mar 14 2018, 5:40 PM

Feb 15 2018

smh added a comment to D14347: Ensure memory consistency on COW.

I don't remember seeing any finalizer related crashes. The failures were mostly malloc-related and looked like they could be caused by arena corruption. I can try to dig up the logs later. I don't recall seeing any build failures on my FX CPU, but lang/go would almost always fail to build on Ryzen.

Feb 15 2018, 11:44 PM
smh added a comment to D14347: Ensure memory consistency on COW.

As noted in my email comment, this patch appears to have resolved a number of randomish-looking ports build failures on my Ryzen machine, in particular lang/go and anything related to lang/guile.

Feb 15 2018, 5:20 PM

Jan 24 2018

smh committed rS328321: Added missing CTLFLAG_VNET to lacp default_strict_mode.
Added missing CTLFLAG_VNET to lacp default_strict_mode
Jan 24 2018, 10:13 AM

Jan 4 2018

smh committed rS327559: Disabled the use of flowid for lagg by default.
Disabled the use of flowid for lagg by default
Jan 4 2018, 8:06 PM

Jan 3 2018

smh committed rS327520: MFC r322812:.
MFC r322812:
Jan 3 2018, 4:16 PM
smh committed rS327519: MFC r322812:.
MFC r322812:
Jan 3 2018, 3:01 PM

Oct 30 2017

smh added a comment to D12809: geom_slice: do not destroy softc until providers are gone.

Nice improvements, I learned some interesting details while following these improvements :-)

Oct 30 2017, 9:16 AM

Oct 28 2017

smh accepted D12809: geom_slice: do not destroy softc until providers are gone.

LGTM

Oct 28 2017, 6:21 PM

Oct 24 2017

smh added reviewers for D12776: Fix mps deadlock when handling panic: scottl, manu.
Oct 24 2017, 2:47 PM
smh created D12776: Fix mps deadlock when handling panic.
Oct 24 2017, 2:46 PM

Oct 2 2017

smh accepted D12528: MFV r323530: 7431 ZFS Channel Programs.
Oct 2 2017, 1:31 PM

Sep 28 2017

smh requested changes to D12528: MFV r323530: 7431 ZFS Channel Programs.

Few nits

Sep 28 2017, 7:37 PM

Aug 31 2017

smh requested changes to D12144: add sysctls for arc shrinking and growing values.
Aug 31 2017, 11:37 AM

Aug 25 2017

smh committed rS322881: Add myself (smh) to calendar.freebsd.
Add myself (smh) to calendar.freebsd
Aug 25 2017, 8:21 AM

Jun 20 2017

smh committed rS320138: Fixed bsdinstall location of vfs.zfs.min_auto_ashift.
Fixed bsdinstall location of vfs.zfs.min_auto_ashift
Jun 20 2017, 8:04 AM
smh closed D11278: Fixed bsdinstall location of vfs.zfs.min_auto_ashift by committing rS320138: Fixed bsdinstall location of vfs.zfs.min_auto_ashift.
Jun 20 2017, 8:04 AM
smh retitled D11278: Fixed bsdinstall location of vfs.zfs.min_auto_ashift from Fixed bsdinstall location of vfs.zfs.min_auto_ashift vfs.zfs.min_auto_ashift is a sysctl only not a tunable so updated bsdinstall to use the correct location /etc/sysctl.conf instead of /boot/loader.conf to Fixed bsdinstall location of vfs.zfs.min_auto_ashift.
Jun 20 2017, 1:30 AM
smh created D11278: Fixed bsdinstall location of vfs.zfs.min_auto_ashift.
Jun 20 2017, 1:29 AM

May 18 2017

smh committed rS318438: Revert the partial MFC of r313045 which broke dtrace.
Revert the partial MFC of r313045 which broke dtrace
May 18 2017, 3:32 AM
smh closed D10769: Revert MFC of r313045 from stable/10 by committing rS318438: Revert the partial MFC of r313045 which broke dtrace.
May 18 2017, 3:32 AM

May 17 2017

smh added a reviewer for D10769: Revert MFC of r313045 from stable/10: markj.
May 17 2017, 8:31 AM
smh created D10769: Revert MFC of r313045 from stable/10.
May 17 2017, 8:30 AM

Apr 26 2017

smh committed rS317470: MFC r315449:.
MFC r315449:
Apr 26 2017, 10:25 PM
smh committed rS317469: MFC r316460:.
MFC r316460:
Apr 26 2017, 10:23 PM

Apr 24 2017

smh committed rS317375: Partial MFC r316676 and the required r313045.
Partial MFC r316676 and the required r313045
Apr 24 2017, 4:31 PM
smh committed rS317368: MFC r316676:.
MFC r316676:
Apr 24 2017, 11:34 AM

Apr 19 2017

smh accepted D10425: net: Add new 10G and 25G media types to if_media.h.

LGTM

Apr 19 2017, 3:40 AM · network

Apr 14 2017

smh committed rS316944: MFC r316313, r316328:.
MFC r316313, r316328:
Apr 14 2017, 10:02 PM
smh committed rS316943: MFC r303863:.
MFC r303863:
Apr 14 2017, 9:49 PM

Apr 11 2017

smh accepted D10359: loader.efi: only fetch zfs pool guid for the actual boot device.

LGM, much cleaner than it was.

Apr 11 2017, 2:03 PM
smh requested changes to D10359: loader.efi: only fetch zfs pool guid for the actual boot device.
Apr 11 2017, 12:34 PM
smh requested changes to D10293: ixgbe(4): Update HEAD (p2) to 3.2.12-k.

Wow that's a lot of changes.

Apr 11 2017, 8:56 AM

Apr 10 2017

smh committed rS316676: Use estimated RTT for receive buffer auto resizing instead of timestamps.
Use estimated RTT for receive buffer auto resizing instead of timestamps
Apr 10 2017, 8:19 AM
smh closed D9668: Support estimated RTT for receive buffer auto resizing by committing rS316676: Use estimated RTT for receive buffer auto resizing instead of timestamps.
Apr 10 2017, 8:19 AM

Apr 8 2017

smh updated the diff for D9668: Support estimated RTT for receive buffer auto resizing.

Convert timestamp to ticks to ensure that comparisons are correct for
hz != 1000.

Apr 8 2017, 10:28 PM

Apr 7 2017

smh added a comment to D9668: Support estimated RTT for receive buffer auto resizing.

Lawrence is now happy with this in is current form, so just a prod to see if I get any comments for or against from transport members / gnn?

Apr 7 2017, 5:56 PM

Apr 3 2017

smh committed rS316460: Fix expandsz 16.0E vals and vdev_min_asize of RAIDZ children.
Fix expandsz 16.0E vals and vdev_min_asize of RAIDZ children
Apr 3 2017, 1:11 PM

Mar 31 2017

smh updated the diff for D9668: Support estimated RTT for receive buffer auto resizing.

Extract common logic to tcp_autorcvbuf as suggested by lstewart.

Mar 31 2017, 4:27 PM
smh committed rS316328: Allow explicitly assigned IPv6 loopback address to be used in jails.
Allow explicitly assigned IPv6 loopback address to be used in jails
Mar 31 2017, 9:11 AM
smh committed rS316313: Allow explicitly assigned IPv4 loopback address to be used in jails.
Allow explicitly assigned IPv4 loopback address to be used in jails
Mar 31 2017, 12:42 AM

Mar 30 2017

smh accepted D10202: Add a new parameter to restrict jails from binding to privileged ports.
Mar 30 2017, 11:58 PM
smh accepted D10202: Add a new parameter to restrict jails from binding to privileged ports.

Some style nits but otherwise LGM

Mar 30 2017, 3:23 PM

Mar 23 2017

smh committed rS315855: MFC r315423:.
MFC r315423:
Mar 23 2017, 10:43 AM

Mar 19 2017

smh added a comment to D9668: Support estimated RTT for receive buffer auto resizing.

Thanks for the feedback Lawrence, based on that I've updated to use just the SRTT check, added the fastpath version and generally cleaned up.

Mar 19 2017, 12:50 PM
smh updated the diff for D9668: Support estimated RTT for receive buffer auto resizing.

Corrected dtrace autoresize mbuf parameter definition.

Mar 19 2017, 12:43 PM
smh added a comment to D9668: Support estimated RTT for receive buffer auto resizing.

Updated dtrace:

dtrace
#!/usr/sbin/dtrace -s
Mar 19 2017, 12:37 PM
smh updated the diff for D9668: Support estimated RTT for receive buffer auto resizing.

Eliminated timestamp specific code path resulting in a simplified yet still effective single SRTT path.

Mar 19 2017, 12:29 PM

Mar 17 2017

smh closed D10012: Reduce ARC fragmentaion threshold by committing rS315449: Reduce ARC fragmentation threshold.
Mar 17 2017, 12:35 PM
smh committed rS315449: Reduce ARC fragmentation threshold.
Reduce ARC fragmentation threshold
Mar 17 2017, 12:35 PM
smh added a reviewer for D10012: Reduce ARC fragmentaion threshold: avg.
Mar 17 2017, 12:14 PM

Mar 16 2017

smh committed rS315423: Fix libsysdecode vmprot flag decoding.
Fix libsysdecode vmprot flag decoding
Mar 16 2017, 8:55 PM
smh added inline comments to D9757: loader: remove open_disk cache.
Mar 16 2017, 10:27 AM

Mar 15 2017

smh added a reviewer for D10012: Reduce ARC fragmentaion threshold: mav.
Mar 15 2017, 12:40 PM
smh created D10012: Reduce ARC fragmentaion threshold.
Mar 15 2017, 12:40 PM

Mar 14 2017

smh accepted D9999: zfs: add zio_buf_alloc_nowait and use it in vdev_queue_aggregate.

LGTM

Mar 14 2017, 1:46 PM

Mar 7 2017

smh requested changes to D9851: ixgbe(4): Update HEAD to 3.2.12-k.

Massive amounts of changes in this so impossible to see if everything is good, however a number of style related bits highlighted, some of which are regressions.

Mar 7 2017, 5:19 PM
smh accepted D9829: Add a summary line of the ZFS Compressed ARC to top(1).
Mar 7 2017, 4:39 PM

Mar 4 2017

smh accepted D9847: Try to extract the RFC1048 data from PXE.
Mar 4 2017, 3:55 AM

Mar 3 2017

smh requested changes to D9847: Try to extract the RFC1048 data from PXE.
Mar 3 2017, 4:32 PM
smh added a comment to D9847: Try to extract the RFC1048 data from PXE.

book -> bool

Mar 3 2017, 6:56 AM
smh added inline comments to D9847: Try to extract the RFC1048 data from PXE.
Mar 3 2017, 6:53 AM

Mar 2 2017

smh requested changes to D9847: Try to extract the RFC1048 data from PXE.
Mar 2 2017, 10:47 PM
smh requested changes to D9847: Try to extract the RFC1048 data from PXE.
Mar 2 2017, 10:02 PM
smh requested changes to D9847: Try to extract the RFC1048 data from PXE.
Mar 2 2017, 5:15 PM

Feb 28 2017

smh added a comment to D9829: Add a summary line of the ZFS Compressed ARC to top(1).
In D9829#203014, @jhb wrote:

I agree with shortening the line a bit so it fits in 80 cols. If you are worried about duplicating "ARC:" you could perhaps just use a whitespace prefix so you end up with something like:

Mem: 754M Active, 836M Inact, 75M Laundry, 3761M Wired, 10G Free
ARC: 2476M Total, 914M MFU, 1302M MRU, 1696K Anon, 140M Header, 118M Other
     1899M Compressed, 6065M Uncompressed, 2.45:1 Ratio, 318M Overhead
Swap: 3072M Total, 3072M Free
Feb 28 2017, 11:19 PM
smh added a comment to D9829: Add a summary line of the ZFS Compressed ARC to top(1).

Some may find it useful if it was bit shorter, currently its 82 chars in the example.

Feb 28 2017, 4:54 PM

Feb 24 2017

smh added a comment to D9611: ZFS ARC: remove TRIM-ing of cache (L2ARC) devices.

Indeed, do you have any bandwidth to do proper testing to prove either way or have you already done this?

Feb 24 2017, 10:10 AM

Feb 23 2017

smh accepted D9485: Make LACP behavior more closely conform to the standard.

LGTM

Feb 23 2017, 5:39 PM
smh accepted D9757: loader: remove open_disk cache.

LGTM

Feb 23 2017, 9:13 AM

Feb 22 2017

smh accepted D9706: loader: update symlink support in zfs reader.

LGTM

Feb 22 2017, 1:42 PM
smh added inline comments to D9706: loader: update symlink support in zfs reader.
Feb 22 2017, 12:32 PM
smh requested changes to D9706: loader: update symlink support in zfs reader.
Feb 22 2017, 9:31 AM
smh added a reviewer for D9668: Support estimated RTT for receive buffer auto resizing: hiren.
Feb 22 2017, 9:17 AM

Feb 21 2017

smh accepted D7421: reimplement zfsctl (.zfs) support.
Feb 21 2017, 5:30 PM
smh requested changes to D7421: reimplement zfsctl (.zfs) support.

Just a few seemingly redundant assignments to error vars, sorry didn't spot them before

Feb 21 2017, 11:24 AM

Feb 20 2017

smh added inline comments to D9668: Support estimated RTT for receive buffer auto resizing.
Feb 20 2017, 9:14 AM
smh updated the diff for D9668: Support estimated RTT for receive buffer auto resizing.

Disabled reset receive buffer auto scaling when not in bulk receive mode, which gives an extra 20% performance increase, bring it closer to Linux.

Feb 20 2017, 9:08 AM

Feb 19 2017

smh updated D9668: Support estimated RTT for receive buffer auto resizing.
Feb 19 2017, 1:43 AM
smh added a comment to D9668: Support estimated RTT for receive buffer auto resizing.

For reference fastpath version of this hasn't been done, which need also need the same changes to:

tcp_stacks/fastpath.c
Feb 19 2017, 1:39 AM