net: Add new 10G and 25G media types to if_media.h
ClosedPublic

Authored by erj on Apr 19 2017, 12:18 AM.

Details

Summary

A new XXV710 (uses the ixl(4) driver) firmware coming out soon is supposed to add support for new Active Optical / Copper cables, so add them here so that they can be displayed in ifconfig.

Also add 25Gbase-LR because that wasn't in the media type list, and should theoretically be already supported by the current cards.

Test Plan

Plug in each of the above mentioned cables and verify that they're displayed in ifconfig.

(Hasn't been tested yet)

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
erj created this revision.Apr 19 2017, 12:18 AM
smh accepted this revision.Apr 19 2017, 3:40 AM
smh added a subscriber: smh.

LGTM

This revision is now accepted and ready to land.Apr 19 2017, 3:40 AM
erj added a comment.Apr 19 2017, 5:52 PM

I kind of want to bump __FreeBSD_version to make it easier for our drivers to see if there's support for these new media types.

emaste added a subscriber: emaste.Apr 19 2017, 7:33 PM
In D10425#216318, @erj wrote:

I kind of want to bump __FreeBSD_version to make it easier for our drivers to see if there's support for these new media types.

__FreeBSD_version numbers aren't that much of a scarce commodity so you could bump it if needed, but what about just #ifdef IFM_10G_AOC etc.?

imp accepted this revision.Apr 19 2017, 7:34 PM

You could ifdef the things for which version supports it. But that interacts poorly with the ports system, so I'd go for it on bumping the FreeBSD_version. It's cheap enough.

In D10425#216333, @imp wrote:

You could ifdef the things for which version supports it. But that interacts poorly with the ports system, so I'd go for it on bumping the FreeBSD_version. It's cheap enough.

I mean in the driver, just do #ifdef IFM_10G_AOC instead of #if __FreeBSD_version >= xxxxxx.
But agreed __FreeBSD_version is cheap enough so it's fine too.

erj added a comment.May 10 2017, 6:15 PM

I've decided against bumping the FreeBSD version number -- there aren't very many defines added here, so adding #ifdef's isn't too big of a deal.

This revision was automatically updated to reflect the committed changes.