Fix pfsync breaking carp
ClosedPublic
Actions

Authored by smh on Jan 18 2019, 12:13 AM.

Tags

None

Referenced Files

	F167177536: D18882.diff
	Wed, Aug 19, 4:38 PM

	F167128440: D18882.diff
	Wed, Aug 19, 8:22 AM

	Unknown Object (File)
	Mon, Aug 17, 2:16 AM

	Unknown Object (File)
	Sat, Aug 15, 2:28 AM

	Unknown Object (File)
	Thu, Aug 13, 2:17 AM

	Unknown Object (File)
	Thu, Aug 13, 1:52 AM

	Unknown Object (File)
	Mon, Aug 3, 8:22 AM

	Unknown Object (File)
	Mon, Aug 3, 7:20 AM

View All Files

Subscribers

farrokhi

imp

Details

Reviewers

Commits

rS343130: pf: fix pfsync breaking carp

Summary

Fix missing initialisation of sc_flags into a valid sync state on clone which breaks carp in pfsync.

This regression was introduce by 342051

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

smh created this revision.Jan 18 2019, 12:13 AM

Herald added subscribers: farrokhi, imp. · View Herald TranscriptJan 18 2019, 12:14 AM

Harbormaster completed remote builds in B22013: Diff 52954.Jan 18 2019, 12:14 AM

smh added a reviewer: kp.Jan 18 2019, 12:16 AM

Yeah, looking at my original commit I did manage to lose that flag. I’ve not tested yet, but this patch is almost certainly correct.

I’ll take a deeper look and commit later today.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 18 2019, 8:20 AM

Closed by commit rS343130: pf: fix pfsync breaking carp (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

netpfil/

pf/

if_pfsync.c

1 line

Diff 52965

View Options

head/sys/netpfil/pf/if_pfsync.c

Fix pfsync breaking carpClosedPublicActions