Page MenuHomeFreeBSD

Fix pfsync breaking carp
ClosedPublic

Authored by smh on Jan 18 2019, 12:13 AM.

Details

Summary

Fix missing initialisation of sc_flags into a valid sync state on clone which breaks carp in pfsync.

This regression was introduce by 342051

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

smh created this revision.Jan 18 2019, 12:13 AM
smh added a reviewer: kp.Jan 18 2019, 12:16 AM
kp added a comment.Jan 18 2019, 12:41 AM

Yeah, looking at my original commit I did manage to lose that flag. I’ve not tested yet, but this patch is almost certainly correct.

I’ll take a deeper look and commit later today.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 18 2019, 8:20 AM
Closed by commit rS343130: pf: fix pfsync breaking carp (authored by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.