Page MenuHomeFreeBSD

kmacy (Kip Macy)
User

Projects

User Details

User Since
Jan 24 2015, 12:39 AM (190 w, 5 d)

Recent Activity

Jun 1 2018

kmacy abandoned D15275: Feature enhancements to pmcstat.
Jun 1 2018, 7:20 PM

May 12 2018

kmacy added inline comments to D15155: Make pmclog buffer pcpu and update constants.
May 12 2018, 12:09 AM

May 11 2018

kmacy added a reviewer for D15155: Make pmclog buffer pcpu and update constants: sbruno.
May 11 2018, 11:31 PM
kmacy added inline comments to D15155: Make pmclog buffer pcpu and update constants.
May 11 2018, 6:13 PM

May 9 2018

kmacy abandoned D15231: create straightforward EBR wrapper with rudimentary support for preemption.

One needs to Jeff's uncommitted locking changes to see any benefit from this if one touches any pages in the mapping and even then it's only a ~20% win because there is then so much contention on the vm page queue mutex. Jeff is hesitant to sink too much energy in to this on behalf of a microbenchmark. There are clear wins to be had elsewhere without the complexity and risk of VM, so dropping this for now.

May 9 2018, 7:05 AM

May 8 2018

kmacy accepted D15343: iflib: mark irq allocation name parameter as constant.

LGTM

May 8 2018, 2:24 AM

May 7 2018

kmacy abandoned D4366: convert tcp timestamps to scaled sbintime.
May 7 2018, 8:00 AM · transport

May 4 2018

Herald added 1 blocking reviewer(s) for D4294: modernize TCP constants: transport.

@lstewart ping

May 4 2018, 6:07 PM · transport
kmacy added a comment to D15275: Feature enhancements to pmcstat.
In D15275#322358, @kib wrote:
In D15275#322071, @kib wrote:

How does an event description from the json tables is matched against the index from pmc_events.h ?

It works so long as the FreeBSD version was named correctly. I have an aliases table pmu_utils.c for things like UNHALTED_CORE_CYCLES and LLC_MISSES. If the table lookup fails it will just use the default sampling rate that is used on HEAD. Ultimately, on supported architectures I'd like to switch from using the ad hoc defines in pmc_events.h to using the json tables from Intel, IBM, and Cavium.

So did you verified that the name matches ? What are the plan for non-matching names ?

May 4 2018, 6:05 PM
kmacy updated the summary of D15275: Feature enhancements to pmcstat.
May 4 2018, 7:37 AM
kmacy accepted D15284: iflib: remove unused brscp pointer from iflib_queues_alloc.
May 4 2018, 7:33 AM
kmacy added a comment to D15275: Feature enhancements to pmcstat.

Hi Andi -
Thanks for the prompt response. I will definitely be taking a look at the upstream version. All I've done so far is add table generation to the build process and use the generated tables to provide sane default sampling rates . https://reviews.freebsd.org/D15275

May 4 2018, 2:36 AM

May 3 2018

kmacy updated the summary of D15275: Feature enhancements to pmcstat.
May 3 2018, 11:23 PM
kmacy added a comment to D15275: Feature enhancements to pmcstat.
In D15275#322071, @kib wrote:

How does an event description from the json tables is matched against the index from pmc_events.h ?

May 3 2018, 11:21 PM
kmacy added a comment to D15231: create straightforward EBR wrapper with rudimentary support for preemption.

@kib Thanks. If I touch a page in the mapping that would be more representative correct? Page faults appear to be globally serialized by the per-domain reservations mutex, so that would likely scale no better than the no-op case without your change or mine.

May 3 2018, 8:39 PM
kmacy added a reviewer for D15231: create straightforward EBR wrapper with rudimentary support for preemption: alc.
May 3 2018, 8:29 PM
kmacy added a comment to D15231: create straightforward EBR wrapper with rudimentary support for preemption.

Actually - @cognet could you please fix man page installation for ck?

May 3 2018, 6:40 PM
kmacy added a comment to D15231: create straightforward EBR wrapper with rudimentary support for preemption.

It looks like the man pages aren't installed for ck. I'll submit a review for that.

May 3 2018, 6:37 PM
kmacy added a reviewer for D15231: create straightforward EBR wrapper with rudimentary support for preemption: markj.
May 3 2018, 6:29 PM
kmacy abandoned D4292: decouple maximum clock frequency from callout scheduling granularity.
May 3 2018, 6:12 PM · transport
kmacy added a comment to D15231: create straightforward EBR wrapper with rudimentary support for preemption.

! In D15231#321789, @kib wrote:
Where is the documentation for the ck epoch, both interface and implementation.

May 3 2018, 5:50 PM
kmacy added a comment to D10556: Update cubic constants.

@shurd @sbruno might one of you commit this?

May 3 2018, 4:10 AM · network
kmacy updated subscribers of D10556: Update cubic constants.
May 3 2018, 4:10 AM · network
kmacy added a comment to D12142: Don't start grouptaskqueue threads for unused grouptaskqueues.

@shurd does this still work or should it be abandoned?

May 3 2018, 4:09 AM
kmacy abandoned D4293: update SRTT to account for flight size.

We needed to refine this further at ISLN.

May 3 2018, 3:56 AM · transport
Herald added a reviewer for D4366: convert tcp timestamps to scaled sbintime: transport.

@lstewart is this worth updating or should I just abandon?

May 3 2018, 3:55 AM · transport
kmacy abandoned D6696: Add VM eventhandlers.

I don't anticipate finding the time to add USERPTR support any time soon.

May 3 2018, 3:54 AM
kmacy accepted D15218: Update iflibdd.9 to reflect the replacement of ifdi_queues_alloc with ifdi_{tx,rx}_queues_alloc.
May 3 2018, 3:51 AM
kmacy added a reviewer for D15218: Update iflibdd.9 to reflect the replacement of ifdi_queues_alloc with ifdi_{tx,rx}_queues_alloc: shurd.
May 3 2018, 3:51 AM
kmacy accepted D15262: Add netdump hooks for iflib..
May 3 2018, 3:44 AM
kmacy updated the summary of D15275: Feature enhancements to pmcstat.
May 3 2018, 2:08 AM
kmacy updated the diff for D15275: Feature enhancements to pmcstat.

remove bogus license tags, the source is clearly BSD from Intel

May 3 2018, 2:01 AM
kmacy updated the diff for D14983: Allow NIC drivers to sleep rather than busy wait.

rebase

May 3 2018, 1:46 AM
kmacy updated the summary of D15275: Feature enhancements to pmcstat.
May 3 2018, 1:25 AM
kmacy updated the summary of D15275: Feature enhancements to pmcstat.
May 3 2018, 1:25 AM
kmacy updated the summary of D15275: Feature enhancements to pmcstat.
May 3 2018, 1:25 AM
kmacy added a reviewer for D15275: Feature enhancements to pmcstat: br.
May 3 2018, 1:24 AM
kmacy updated the summary of D15275: Feature enhancements to pmcstat.
May 3 2018, 1:09 AM
kmacy created D15275: Feature enhancements to pmcstat.
May 3 2018, 1:07 AM
kmacy updated the diff for D15155: Make pmclog buffer pcpu and update constants.

Fix compile issues on non tier 1 architectures

May 3 2018, 12:58 AM

May 2 2018

kmacy accepted D15219: Add a manual page for iflib.9 so that man iflib is useful.
May 2 2018, 12:33 AM
kmacy abandoned D15232: replace locking in swap reservation with fetchadd.
May 2 2018, 12:32 AM

Apr 30 2018

kmacy updated the test plan for D14969: separate out list manipulation locking from state change in multicast.
Apr 30 2018, 11:03 PM
kmacy updated the diff for D14969: separate out list manipulation locking from state change in multicast.

Fix various panics under v6 as well as world build issue

Apr 30 2018, 11:01 PM
kmacy updated subscribers of D15231: create straightforward EBR wrapper with rudimentary support for preemption.
Apr 30 2018, 3:37 PM
kmacy updated the summary of D15232: replace locking in swap reservation with fetchadd.
Apr 30 2018, 7:53 AM
kmacy created D15233: make ucred thread private.
Apr 30 2018, 7:31 AM
kmacy created D15232: replace locking in swap reservation with fetchadd.
Apr 30 2018, 7:25 AM
kmacy created D15231: create straightforward EBR wrapper with rudimentary support for preemption.
Apr 30 2018, 7:21 AM

Apr 28 2018

kmacy added a reviewer for D15219: Add a manual page for iflib.9 so that man iflib is useful: shurd.
Apr 28 2018, 4:27 AM
kmacy added a reviewer for D15155: Make pmclog buffer pcpu and update constants: markj.
Apr 28 2018, 12:33 AM
kmacy updated the diff for D15155: Make pmclog buffer pcpu and update constants.
  • spinlock_{enter, exit} are only gratuitous in functions only called from hardclock.
  • add copyright to the two heavily modified files
Apr 28 2018, 12:29 AM

Apr 25 2018

kmacy updated the diff for D15155: Make pmclog buffer pcpu and update constants.

remove gratuitous spinlock_{enter,exit} calls

Apr 25 2018, 6:40 AM
kmacy updated the summary of D15155: Make pmclog buffer pcpu and update constants.
Apr 25 2018, 5:21 AM
kmacy updated the summary of D15155: Make pmclog buffer pcpu and update constants.
Apr 25 2018, 5:20 AM
kmacy updated the summary of D15155: Make pmclog buffer pcpu and update constants.
Apr 25 2018, 5:10 AM
kmacy updated the summary of D15155: Make pmclog buffer pcpu and update constants.
Apr 25 2018, 5:08 AM
kmacy updated the diff for D15155: Make pmclog buffer pcpu and update constants.
  • make buffer count a function of the number of cpus
  • allocate buffers and per-cpu structures from the right domain
  • reduce nsamples to the number required assuming at most ~8 samples per tick
Apr 25 2018, 5:01 AM

Apr 23 2018

kmacy updated the diff for D15155: Make pmclog buffer pcpu and update constants.

Fix most false sharing in pmc

Apr 23 2018, 7:09 PM
kmacy updated the summary of D15155: Make pmclog buffer pcpu and update constants.
Apr 23 2018, 7:01 PM

Apr 22 2018

kmacy updated the summary of D15155: Make pmclog buffer pcpu and update constants.
Apr 22 2018, 7:39 AM
kmacy updated the summary of D15155: Make pmclog buffer pcpu and update constants.
Apr 22 2018, 7:39 AM
kmacy updated the summary of D15155: Make pmclog buffer pcpu and update constants.
Apr 22 2018, 7:20 AM
kmacy updated the summary of D15155: Make pmclog buffer pcpu and update constants.
Apr 22 2018, 7:06 AM
kmacy created D15155: Make pmclog buffer pcpu and update constants.
Apr 22 2018, 5:30 AM

Apr 11 2018

kmacy resigned from D2404: Handle vm_phys returning NULL in vm_page_alloc().
Apr 11 2018, 12:07 AM
kmacy reclaimed D6585: Avoid naming collisions between linuxkpi's struct device and FreeBSD's struct device .
Apr 11 2018, 12:07 AM
kmacy abandoned D6585: Avoid naming collisions between linuxkpi's struct device and FreeBSD's struct device .
Apr 11 2018, 12:07 AM
kmacy abandoned D6693: Don't declare legacy framebuffer registration routines if DRM4 is defined.
Apr 11 2018, 12:06 AM

Apr 9 2018

kmacy resigned from D1809: [sockbuf] Don't expose lock details when isn't needed.
Apr 9 2018, 8:05 PM
kmacy resigned from D2211: Patch to reduce use of global IP ID value(s).
Apr 9 2018, 8:05 PM
kmacy updated the diff for D14967: split out flag manipulation from general context manipulation in iflib.
  • check watchdog and reset flags with lock held
  • clear watchdog flag
Apr 9 2018, 6:31 PM
kmacy added a comment to D15010: add white listing for ZFS locking pairs that WITNESS can't report accurately and enable WITNESS by default in ZFS.
In D15010#316190, @mav wrote:

I am not closely familiar with WITNESS, so just a feeling: the long lists of blessed locks and their combinations promises high chances for them to be forgotten on following ZFS updates.

Apr 9 2018, 5:41 PM
kmacy added a comment to D15010: add white listing for ZFS locking pairs that WITNESS can't report accurately and enable WITNESS by default in ZFS.

@markj you can find my attempt at that here https://github.com/mattmacy/networking/tree/projects/witnessfix2 -- you can have a go at it. If you don't have the time / inclination I'd _really_ appreciate it if we didn't let the best become the enemy of the good. If we want stacks of reversals we can comment out blessed entries.

Apr 9 2018, 6:10 AM
kmacy added a comment to D15010: add white listing for ZFS locking pairs that WITNESS can't report accurately and enable WITNESS by default in ZFS.

Why not set WITNESS_BLESSED when the first reversal is detected, and have blessed() return true if WITNESS_BLESSED is set? Then the implementation will still be cheap and we could retain the option of logging the stacks, so investigating the reversals will be easier.

Apr 9 2018, 6:07 AM
kmacy updated the diff for D14969: separate out list manipulation locking from state change in multicast.

add v6 support and witness update

Apr 9 2018, 4:46 AM
kmacy abandoned D6695: Add spare pointer to vm map.
Apr 9 2018, 4:44 AM
kmacy added a comment to D15010: add white listing for ZFS locking pairs that WITNESS can't report accurately and enable WITNESS by default in ZFS.

Why not set WITNESS_BLESSED when the first reversal is detected, and have blessed() return true if WITNESS_BLESSED is set? Then the implementation will still be cheap and we could retain the option of logging the stacks, so investigating the reversals will be easier.

Apr 9 2018, 4:43 AM

Apr 8 2018

kmacy updated the diff for D15010: add white listing for ZFS locking pairs that WITNESS can't report accurately and enable WITNESS by default in ZFS.

Don't include extra changes

Apr 8 2018, 4:39 AM
kmacy updated the summary of D15010: add white listing for ZFS locking pairs that WITNESS can't report accurately and enable WITNESS by default in ZFS.
Apr 8 2018, 4:35 AM
kmacy updated the diff for D15010: add white listing for ZFS locking pairs that WITNESS can't report accurately and enable WITNESS by default in ZFS.

fix typo

Apr 8 2018, 4:30 AM
kmacy updated the diff for D15010: add white listing for ZFS locking pairs that WITNESS can't report accurately and enable WITNESS by default in ZFS.

add full context

Apr 8 2018, 4:28 AM
kmacy updated the diff for D15010: add white listing for ZFS locking pairs that WITNESS can't report accurately and enable WITNESS by default in ZFS.

add mls->mls_lock + dl->dl_lock

Apr 8 2018, 4:25 AM
kmacy updated the summary of D15010: add white listing for ZFS locking pairs that WITNESS can't report accurately and enable WITNESS by default in ZFS.
Apr 8 2018, 4:17 AM
kmacy updated the summary of D15010: add white listing for ZFS locking pairs that WITNESS can't report accurately and enable WITNESS by default in ZFS.
Apr 8 2018, 3:53 AM
kmacy updated subscribers of D15010: add white listing for ZFS locking pairs that WITNESS can't report accurately and enable WITNESS by default in ZFS.
Apr 8 2018, 3:49 AM
kmacy added a reviewer for D15010: add white listing for ZFS locking pairs that WITNESS can't report accurately and enable WITNESS by default in ZFS: markj.
Apr 8 2018, 3:43 AM
kmacy updated the summary of D15010: add white listing for ZFS locking pairs that WITNESS can't report accurately and enable WITNESS by default in ZFS.
Apr 8 2018, 3:43 AM
kmacy created D15010: add white listing for ZFS locking pairs that WITNESS can't report accurately and enable WITNESS by default in ZFS.
Apr 8 2018, 3:39 AM

Apr 6 2018

kmacy added a comment to D14967: split out flag manipulation from general context manipulation in iflib.
In D14967#315442, @erj wrote:

I don't see the console hanging on the version of ixl-iflib where I did see them when watchdogs happened, so this appears to fix the deadlock in that situation.

Apr 6 2018, 7:26 PM
kmacy updated subscribers of D14983: Allow NIC drivers to sleep rather than busy wait.
Apr 6 2018, 1:24 AM
kmacy updated subscribers of D14982: Make BPF global lock an SX to allow NIC drivers to sleep on polling config operations.
Apr 6 2018, 1:22 AM
kmacy updated subscribers of D14969: separate out list manipulation locking from state change in multicast.
Apr 6 2018, 1:22 AM
kmacy updated subscribers of D14967: split out flag manipulation from general context manipulation in iflib.
Apr 6 2018, 1:22 AM
kmacy abandoned D12101: swfw_sync DELAY -> sleep conversion.

Split in to many separate reviews.

Apr 6 2018, 1:09 AM · network
kmacy added a child revision for D14983: Allow NIC drivers to sleep rather than busy wait: D14984: Sleep rather than spin in e1000 when doing long running config operations.
Apr 6 2018, 1:07 AM
kmacy created D14984: Sleep rather than spin in e1000 when doing long running config operations.
Apr 6 2018, 1:07 AM
kmacy created D14983: Allow NIC drivers to sleep rather than busy wait.
Apr 6 2018, 1:04 AM
kmacy added a child revision for D14967: split out flag manipulation from general context manipulation in iflib: D14983: Allow NIC drivers to sleep rather than busy wait.
Apr 6 2018, 1:04 AM
kmacy added a child revision for D14969: separate out list manipulation locking from state change in multicast: D14983: Allow NIC drivers to sleep rather than busy wait.
Apr 6 2018, 1:04 AM