Allow NIC drivers to sleep rather than busy wait
ClosedPublic
Actions

Authored by kmacy on Apr 6 2018, 1:04 AM.

Details

Reviewers

Commits

rS333218: Allow iflib NIC drivers to sleep rather than busy wait

Summary

Since the move to SMP NIC driver locking has had to go through serious contortions using mtx around long running hardware operations. This moves iflib past that.

This change depends on D14967, D14969, and D14982

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kmacy created this revision.Apr 6 2018, 1:04 AM

Herald added subscribers: ae, imp. · View Herald TranscriptApr 6 2018, 1:04 AM

Harbormaster completed remote builds in B16008: Diff 41163.Apr 6 2018, 1:04 AM

kmacy added a child revision: D14984: Sleep rather than spin in e1000 when doing long running config operations.Apr 6 2018, 1:07 AM

kmacy added a subscriber: sbruno.Apr 6 2018, 1:24 AM

shurd added inline comments.Apr 9 2018, 4:36 PM

sys/net/iflib.c
2156 ↗	(On Diff #41163)	errant whitespace?
2161 ↗	(On Diff #41163)	IFC_DO_WATCHDOG is never cleared...
3738 ↗	(On Diff #41163)	Shouldn't this test be protected by the lock as well?
4434 ↗	(On Diff #41163)	errant whitespace?