igc already does not panic per your own statement, so I'm not sure what you are arguing. My request is to unify lifecycle management as one commit. But now looking and iflib.c I think the igc_if_init should simply be dropped from resume and media_change so please do that instead.

@kbowling resume and media_change are not the same. They already inside a CTX_LOCK already, no panic.

It's one unit of work unifying a lifecycle issue

In D58629#1345834, @kbowling wrote:

Can you do the same for media_change and if_resume?

Can you do the same for media_change and if_resume?

Can you do the same for media_change and if_resume?

Thank you for the feedback. After applying (only) the suggested change, testing a EEE state change with my hardware looks like the following:

root@freebsd:/usr/src # sysctl dev.ix.1.eee_state
dev.ix.1.eee_state: 1
root@freebsd:/usr/src # sysctl dev.ix.1.eee_state=0
dev.ix.1.eee_staix1: Error in EEE setup: 0x7FFFFFFF
te: 1
sysctl: dev.ix.1.eee_state=0: Invalid argument
root@freebsd:/usr/src #

Tested with a 1000 iteration ifdown/up loop using both DA and SR, configured normally and using LAGG.