Differential D48987

Fix vlan priority on lem
ClosedPublic
Actions

Authored by anaelle.cazuc_stormshield.eu on Feb 13 2025, 10:43 AM.

Tags

Referenced Files

	F166322274: D48987.id150986.diff
	Wed, Aug 12, 9:55 PM

	Unknown Object (File)
	Wed, Aug 12, 3:38 PM

	Unknown Object (File)
	Mon, Aug 10, 9:14 AM

	Unknown Object (File)
	Sun, Aug 9, 2:37 PM

	Unknown Object (File)
	Sat, Aug 8, 5:57 PM

	Unknown Object (File)
	Sat, Aug 8, 12:17 AM

	Unknown Object (File)
	Fri, Aug 7, 3:03 PM

	Unknown Object (File)
	Thu, Aug 6, 8:46 PM

Subscribers

Details

Reviewers

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rGe812e4d86d28: e1000: Fix vlan PCP/DEI on lem(4)
rGecbef369b33a: e1000: Fix vlan PCP/DEI on lem(4)
rG4b29599fbbe3: e1000: Fix vlan PCP/DEI on lem(4)

Summary

The vlan priority and CFI tag are discarded when receiving vlan packets on lem interfaces
According to the 82540 SDM, the PRI & CFI fields are handled by lem nic, so there's no reason to discard them (em / igb / igc keep them)
The PRI / CFI shift & and mask defines are added for the sake of completeness

Sponsored by: Stormshield

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

anaelle.cazuc_stormshield.eu created this revision.Feb 13 2025, 10:43 AM

Owners added a reviewer: Restricted Owners Package.Feb 13 2025, 10:43 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 13 2025, 10:43 AM

anaelle.cazuc_stormshield.eu requested review of this revision.Feb 13 2025, 10:43 AM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2025, 6:23 PM

Closed by commit rG4b29599fbbe3: e1000: Fix vlan PCP/DEI on lem(4) (authored by Aurelien Cazuc <aurelien.cazuc.external@stormshield.eu>, committed by Kevin Bowling <kbowling@FreeBSD.org>). · Explain Why

This revision was automatically updated to reflect the committed changes.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG4b29599fbbe3: e1000: Fix vlan PCP/DEI on lem(4).

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGecbef369b33a: e1000: Fix vlan PCP/DEI on lem(4).Feb 16 2025, 12:26 AM

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGe812e4d86d28: e1000: Fix vlan PCP/DEI on lem(4).

Revision Contents
Changeset List

Path

Size

sys/

dev/

e1000/

e1000_defines.h

1 line

3 lines

Diff 150986

sys/dev/e1000/e1000_defines.h

Loading...

sys/dev/e1000/em_txrx.c

Loading...