Thank you for the feedback. After applying (only) the suggested change, testing a EEE state change with my hardware looks like the following:

root@freebsd:/usr/src # sysctl dev.ix.1.eee_state
dev.ix.1.eee_state: 1
root@freebsd:/usr/src # sysctl dev.ix.1.eee_state=0
dev.ix.1.eee_staix1: Error in EEE setup: 0x7FFFFFFF
te: 1
sysctl: dev.ix.1.eee_state=0: Invalid argument
root@freebsd:/usr/src #

Tested with a 1000 iteration ifdown/up loop using both DA and SR, configured normally and using LAGG.

In D17646#379198, @linimon wrote:

I'm not sure that PORTEPOCH can start with zero.

I'm not sure that PORTEPOCH can start with zero.

In D17646#376890, @franco_opnsense.org wrote:

@skozlov feel free to take maintainership of net/intel-em-kmod and thanks for working on these modules! :)

@skozlov feel free to take maintainership of net/intel-em-kmod and thanks for working on these modules! :)

Original patch committed in r481900
The revision wasn't automatically closed because I wasn't able to use the arcanist properly :(

net/intel-{ix,em}-kmod: freeze PORTREVISION and PORTEPOCH

Any last-minute assents or objections?

I'll add -Wno-error to the master port, but because of the amount of testing it will require - I'd like to make it a separate review.

Add X5* controllers to supported list

Sorry the first part of my comment made no sense, ixl is the pf and will remain for 25/40g hw parts.

Can you rename the sys/dev/ixl dir to iavf as part of this? I'd really like to see this change done now in 12.0, it would be very awkward to try and MFC later.

In D17443#372892, @skozlov wrote:

In D17443#372344, @koobs wrote:

Looks good except for -Werror. This all matches the port WIP I have in my tree, except for the additions:

MANPAGENAME=        ixgbe
MANPAGELINKS=        ix if_ix if_ixgbe
​MAX_NETMAP_OSVERSION=        1199999  # Doesn't build w/NETMAP on 12

Will do. Do you have any specific warnings showing up for you?

In D17443#372344, @koobs wrote:

Looks good except for -Werror. This all matches the port WIP I have in my tree, except for the additions:

MANPAGENAME=        ixgbe
MANPAGELINKS=        ix if_ix if_ixgbe
​MAX_NETMAP_OSVERSION=        1199999  # Doesn't build w/NETMAP on 12

Looks good, thanks!

Looks good except for -Werror. This all matches the port WIP I have in my tree, except for the additions:

In D17443#372074, @sbruno wrote:

Does this require a LICENSE or some sort?

Does this require a LICENSE or some sort?

• iavf(4): Move modules/Makefile entry so that it's in alphabetical order
• iavf(4): Update MODULE_* macros with new "iavf" name

• ixlv/iavf(4): Change "ixlv" driver name to "iavf"

Ugh, rebasing changes the commit SHAs :(

Rebased onto latest master, and added:

• Revert "iflib: Free RX queue TCP LRO memory on unload"

• ixlv(4): Update driver version to 2.0.0-k
• ixlv(4): Remove dynamic ITR code, since it's unused
• ixlv(4): Set max number of queues used in iflib based on number VF receives from PF
• ixlv(4): Code cleanup
• ixlv(4): Don't sleep for a response to a VC msg if driver is in detach
• ixl(4): Clear VF qtag queue flags when VF is being reinitialized
• ixlv(4): Move queue disable to earlier in ixlv_if_init, and don't sleep for completion
• ixlv(4): Modify debug prints, and stop printing out "Queue already enabled" warnings
• ixl(4): Update version number to 2.1.0-k

• ixl(4): Fix filter handling when SR-IOV is enabled
• Revert "iflib: Free RX queue TCP LRO memory on unload"

• ixl(4): Fix compile error introduced by previous commit

• ixl(4): Configure promiscuous mode during driver init

• ixlv(4): Disable queues before initialization.

In D16428#360259, @mmacy wrote:

I'm confused; this is just doing a normal store / load for the in detach - you need a lock to serialize reading it with other operations.

Tested with a RHEL7.4 host w/ KVM using both port and host-based VLANs w/ 9710 MTU.

Works in all of my testing. Please commit!

• ixlv(4): Swap MALLOC_DEFINE/DECLARE statements
• ixlv(4): Remove commented out code
• ixlv(4): Check return value of ixlv_add_mac_filter when adding MC addresses
• ixlv(4): Update some debug printf()'s to use newer debug functions
• ixlv(4): malloc() the correct size for the heads of the MAC/vlan filter lists

• iflib: Destroy state lock at end of iflib_device_deregister()
• iflib: Move ifc_in_detach variable to flag in if_ctx_t's ifc_flags, and lock around it

• iflib: Destroy state lock at end of iflib_device_deregister()
• iflib: Move ifc_in_detach variable to flag in if_ctx_t's ifc_flags, and lock around it
• ixl(4): Fix kernel panic during init() when Admin Queue is not alive

• ixl/ixlv Missing semicolon in DWB fix

I'm confused; this is just doing a normal store / load for the in detach - you need a lock to serialize reading it with other operations.

• ixl(4): Fix memory leak when head writeback is disabled

• ixl/ixlv(4): Fix TXD credits update for DWB mode

• ixlv(4): Make ixlv_if_init() and ixlv_stop() wait for ENABLE/DISABLE queue command completion
• ixl(4): Cosmetic change to message PF sends in reply to VF promiscuous config message

• ixl(4): Fix RX MDD event display
• ixl/ixlv(4): Add more MPASS statements to TX path

• ixl(4): Enhance Malicious Driver Detection messages with VF information
• ixl(4): Print out additional event information when a LAN Overflow Event occurs
• ixl/ixlv(4): Add additional MPASS() asserts to the driver TX path

• ixlv(4): Change remaining M_DEVBUF malloc types to M_IXLV
• ixlv(4): Fix a memory leak when interrupt setup fails
• ixlv(4): Convert some malloc()'s to M_WAITOK from M_NOWAIT
• ixlv(4): Remove comments and commented out code
• ixlv(4): Remove list of media types displayed in "ifconfig -m"

• iflib: Free remaining interrupt resources on failure in iflib_device_register()
• iflib: Free RX queue TCP LRO memory on unload

• ixl/ixlv(4): Fix panic when receiving jumbo frame (>4k mtu) traffic

Several outstanding issues:

• ixl(4): Fix compile error when PCI_IOV isn't defined