Page MenuHomeFreeBSD

net/intel-{ix,em}-kmod: freeze PORTREVISION and PORTEPOCH
ClosedPublic

Authored by skozlov on Oct 22 2018, 11:27 AM.
Referenced Files
Unknown Object (File)
Mon, May 27, 1:33 PM
Unknown Object (File)
May 6 2024, 2:53 AM
Unknown Object (File)
Apr 30 2024, 1:44 PM
Unknown Object (File)
Apr 26 2024, 8:00 PM
Unknown Object (File)
Apr 20 2024, 1:36 PM
Unknown Object (File)
Apr 13 2024, 2:30 PM
Unknown Object (File)
Apr 12 2024, 7:22 AM
Unknown Object (File)
Apr 11 2024, 11:15 AM
Subscribers

Details

Summary

PORTREVISION wasn't specified in net/intel-{ix,em}-kmod, which are
slave ports of net/intel-ixl-kmod. Because of that when PORTREVISION
was bumped in intel-ixl-kmod - it automatically appeared in the slave
ports, which shouldn't happen.

To avoid this in the future - explicitly specify PORTREVISION and
PORTEPOCH in the slave ports.

Test Plan

Sanity and compile tested using poudriere w/portlint.


Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

@skozlov feel free to take maintainership of net/intel-em-kmod and thanks for working on these modules! :)

This revision is now accepted and ready to land.Oct 22 2018, 11:31 AM

@skozlov feel free to take maintainership of net/intel-em-kmod and thanks for working on these modules! :)

Thank you. Will do in another commit.

I'm not sure that PORTEPOCH can start with zero.

I'm not sure that PORTEPOCH can start with zero.

This can be done. From Porter's Handbook:

... If PORTEPOCH is nonzero it is appended to the package name ...

Also, portlint doesn't give any warnings, and poudriere builds w/o errors

This revision was automatically updated to reflect the committed changes.