Page MenuHomeFreeBSD
Differential D17061

ix(4), ixv(4): Add VLAN tag strip check when receiving packets; ixv(4): Fix support for VLAN_HWTAGGING and VLAN_HWFILTER flags
ClosedPublic
Actions

Authored by piotr.pietruszewski_intel.com on Sep 6 2018, 10:48 AM.
Tags
Referenced Files
F168023609: D17061.diff
Tue, Aug 25, 11:42 PM
Unknown Object (File)
Thu, Aug 13, 1:49 PM
Unknown Object (File)
Sat, Aug 8, 7:57 PM
Unknown Object (File)
Sat, Aug 8, 6:24 PM
Unknown Object (File)
Sat, Aug 8, 4:09 PM
Unknown Object (File)
Mon, Aug 3, 11:32 PM
Unknown Object (File)
Mon, Aug 3, 5:20 AM
Unknown Object (File)
Sun, Aug 2, 5:27 AM
View All Files
Subscribers
ae
imp
jeffrey.e.pieper_intel.com

Details

Reviewers
sbruno
lukasz.szczepaniak_intel.com
cperciva
jeffrey.e.pieper_intel.com
Group Reviewers
Intel Networking
Commits
rS338593: ix(4), ixv(4): VLAN tag stripping fixes for Amazon EC2 Enhanced Networking
Summary

This change will prevent driver from passing VLAN tags when
interface configuration is not expecting them. VF driver will
check for VLAN_HWTAGGING and VLAN_HWFILTER flags and act adequately.

This patch resolves problem occuring on EC2 platforms.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

piotr.pietruszewski_intel.com created this revision.Sep 6 2018, 10:48 AM
Herald added a reviewer: sbruno. · View Herald TranscriptSep 6 2018, 10:48 AM
Herald added a subscriber: ae. · View Herald Transcript
Harbormaster completed remote builds in B19433: Diff 47724.Sep 6 2018, 12:25 PM
piotr.pietruszewski_intel.com added reviewers: Intel Networking, lukasz.szczepaniak_intel.com.Sep 6 2018, 1:19 PM
piotr.pietruszewski_intel.com added a project: Intel Networking.
piotr.pietruszewski_intel.com added a reviewer: cperciva.Sep 6 2018, 1:58 PM
cperciva accepted this revision.Sep 7 2018, 6:32 PM

Works in all of my testing. Please commit!

jeffrey.e.pieper_intel.com accepted this revision.Sep 11 2018, 1:19 PM
jeffrey.e.pieper_intel.com added a subscriber: jeffrey.e.pieper_intel.com.

Tested with a RHEL7.4 host w/ KVM using both port and host-based VLANs w/ 9710 MTU.

This revision is now accepted and ready to land.Sep 11 2018, 1:19 PM
Closed by commit rS338593: ix(4), ixv(4): VLAN tag stripping fixes for Amazon EC2 Enhanced Networking (authored by erj). · Explain WhySep 11 2018, 6:33 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptSep 11 2018, 6:33 PM

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
ixgbe/
30 lines
3 lines

Diff 47921

View Options

head/sys/dev/ixgbe/if_ixv.c

Loading...
View Options

head/sys/dev/ixgbe/ix_txrx.c

Loading...