igc: defer sysctl-driven reinit to the admin task

[guest-seuros]

Summary

igc_sysctl_eee() and igc_sysctl_dmac() called igc_if_init() directly.

Requested the reset through iflib instead, and skipping while the interface
is down; the new value is picked up by the next init.

This is the same defect fixed for e1000 in D58628. Unlike e1000, igc has
no ASSERT_CTX_LOCK_HELD and no acquire_swflag path, so the defect is
silent here rather than an assertion failure.

MFC: 1 week

Test Plan

Verified on an Intel I225-LM (igc0, 8086:15f2): eee_control 0/1 and dmac
250/1000/1/0 plus an illegal value all reinitialize cleanly, no panic,
and the link recovers after each write.

[kbowling]

Can you do the same for media_change and if_resume?

[guest-seuros]

In D58629#1345834, @kbowling wrote:

Can you do the same for media_change and if_resume?

Yes, but i do not know how to trigger the panic, so i said i could do it in a follow-up diff.

[kbowling]

It's one unit of work unifying a lifecycle issue

[guest-seuros]

@kbowling resume and media_change are not the same. They already inside a CTX_LOCK already, no panic.

[kbowling]

igc already does not panic per your own statement, so I'm not sure what you are arguing. My request is to unify lifecycle management as one commit. But now looking and iflib.c I think the igc_if_init should simply be dropped from resume and media_change so please do that instead.