e1000, igc: drop redundant init from resume and media_change
AbandonedPublic
Actions

Authored by seuros on Tue, Aug 4, 10:36 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Aug 30, 8:12 AM

	Unknown Object (File)
	Tue, Aug 25, 8:16 PM

	Unknown Object (File)
	Mon, Aug 24, 9:00 PM

	Unknown Object (File)
	Mon, Aug 24, 5:09 PM

	Unknown Object (File)
	Sun, Aug 23, 12:37 AM

	Unknown Object (File)
	Wed, Aug 19, 4:59 PM

	Unknown Object (File)
	Mon, Aug 17, 9:57 AM

	Unknown Object (File)
	Mon, Aug 17, 12:00 AM

View All 25 Files

Subscribers

imp

Details

Reviewers

kbowling
adrian

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Summary

iflib_if_init_locked() already runs after IFDI_RESUME and
IFDI_MEDIA_CHANGE, so the trailing *_if_init() only added an unstopped
IFDI_INIT that the following iflib_stop() undoes.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 75368
Build 72251: arc lint + arc unit

Event Timeline

seuros created this revision.Tue, Aug 4, 10:36 PM

Owners added a reviewer: Restricted Owners Package.Tue, Aug 4, 10:36 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Aug 4, 10:36 PM

seuros requested review of this revision.Tue, Aug 4, 10:36 PM

Harbormaster completed remote builds in B75368: Diff 183403.Tue, Aug 4, 10:36 PM

seuros added a parent revision: D58629: igc: defer sysctl-driven reinit to the admin task.Tue, Aug 4, 10:37 PM

Committed as abdde8b602813753e423610b39be6806da5647e2 and 30ccf2f48c11e54fc0540510dcec7cd006a2c366

seuros abandoned this revision.Wed, Aug 5, 9:34 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

e1000/

if_em.c

4 lines

igc/

if_igc.c

4 lines

Diff 183403

View Options

sys/dev/e1000/if_em.c