e1000, igc: drop redundant init from resume and media_change
AbandonedPublic
Actions

Authored by seuros on Aug 4 2026, 10:36 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Sep 11, 2:19 AM

	Unknown Object (File)
	Sun, Sep 6, 6:19 PM

	Unknown Object (File)
	Sun, Sep 6, 3:18 PM

	Unknown Object (File)
	Sun, Sep 6, 2:20 PM

	Unknown Object (File)
	Sun, Sep 6, 2:18 PM

	Unknown Object (File)
	Sun, Sep 6, 10:09 AM

	Unknown Object (File)
	Sat, Sep 5, 5:16 PM

	Unknown Object (File)
	Thu, Sep 3, 4:38 PM

View All 35 Files

Subscribers

imp

Details

Reviewers

kbowling
adrian

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Summary

iflib_if_init_locked() already runs after IFDI_RESUME and
IFDI_MEDIA_CHANGE, so the trailing *_if_init() only added an unstopped
IFDI_INIT that the following iflib_stop() undoes.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 75368
Build 72251: arc lint + arc unit

Event Timeline

seuros created this revision.Aug 4 2026, 10:36 PM

Owners added a reviewer: Restricted Owners Package.Aug 4 2026, 10:36 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 4 2026, 10:36 PM

seuros requested review of this revision.Aug 4 2026, 10:36 PM

Harbormaster completed remote builds in B75368: Diff 183403.Aug 4 2026, 10:36 PM

seuros added a parent revision: D58629: igc: defer sysctl-driven reinit to the admin task.Aug 4 2026, 10:37 PM

Committed as abdde8b602813753e423610b39be6806da5647e2 and 30ccf2f48c11e54fc0540510dcec7cd006a2c366

seuros abandoned this revision.Aug 5 2026, 9:34 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

e1000/

if_em.c

4 lines

igc/

if_igc.c

4 lines

Diff 183403

View Options

sys/dev/e1000/if_em.c