ixl(4): Add ability to control link state on ifconfig down
ClosedPublic
Actions

Authored by krzysztof.galazka_intel.com on Jan 7 2021, 8:38 PM.

Details

Reviewers

gowtham.kumar.ks_intel.com
erj

Group Reviewers

Intel Networking

Commits

rG643f587c95dd: ixl(4): Add ability to control link state on ifconfig down
rGf9c8aed24422: ixl(4): Add ability to control link state on ifconfig down
rG2b94bda05a6d: ixl(4): Add ability to control link state on ifconfig down
rG21802a127d83: ixl(4): Add ability to control link state on ifconfig down

Summary

Add sysctl link_active_on_if_down, which allows user to control
if interface is kept in active state when it is brought
down with ifconfig. Set it to enabled by default to preserve
backwards compatibility.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

krzysztof.galazka_intel.com created this revision.Jan 7 2021, 8:38 PM

Herald added a subscriber: ae. · View Herald TranscriptJan 7 2021, 8:38 PM

krzysztof.galazka_intel.com requested review of this revision.Jan 7 2021, 8:38 PM

Harbormaster completed remote builds in B36005: Diff 81832.Jan 7 2021, 8:38 PM

Fix unqualified transceivers reporting

Driver was showing false positive messages about unqualified transceiver when link_active_on_if_down sysctl was set to 0 and link state changed to down.

Herald added a subscriber: imp. · View Herald TranscriptJan 13 2021, 1:46 PM

Harbormaster completed remote builds in B36169: Diff 82206.Jan 13 2021, 1:47 PM

gowtham.kumar.ks_intel.com accepted this revision.Jan 20 2021, 7:35 AM

This revision is now accepted and ready to land.Jan 20 2021, 7:35 AM

erj accepted this revision.Mar 3 2021, 1:42 AM

Closed by commit rG21802a127d83: ixl(4): Add ability to control link state on ifconfig down (authored by krzysztof.galazka_intel.com, committed by erj). · Explain WhyMar 3 2021, 1:50 AM

This revision was automatically updated to reflect the committed changes.

erj added a commit: rG21802a127d83: ixl(4): Add ability to control link state on ifconfig down.

erj added a commit: rG2b94bda05a6d: ixl(4): Add ability to control link state on ifconfig down.Mar 5 2021, 1:24 AM

erj added a commit: rGf9c8aed24422: ixl(4): Add ability to control link state on ifconfig down.Mar 11 2021, 1:14 AM

stallamr_netapp.com mentioned this in D30733: ixl(4): Fix reporting of unqualified transceivers.Jun 11 2021, 5:05 PM

erj added a commit: rG643f587c95dd: ixl(4): Add ability to control link state on ifconfig down.Sep 20 2021, 11:24 PM