Page MenuHomeFreeBSD

Remove redeclaration found by gcc build
ClosedPublic

Authored by lwhsu on Aug 5 2020, 5:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 31, 3:31 PM
Unknown Object (File)
Sun, May 18, 4:22 PM
Unknown Object (File)
Sat, May 10, 1:23 AM
Unknown Object (File)
Apr 28 2025, 6:41 AM
Unknown Object (File)
Apr 21 2025, 5:29 AM
Unknown Object (File)
Apr 21 2025, 5:18 AM
Unknown Object (File)
Apr 12 2025, 8:45 AM
Unknown Object (File)
Mar 17 2025, 6:38 AM

Details

Summary

Remove redeclaration found by gcc build

i40e_blink_phy_link_led is declared twice in this file.

Test Plan

Build with gcc and clang.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lwhsu requested review of this revision.Aug 5 2020, 5:38 AM
lwhsu edited the test plan for this revision. (Show Details)
lwhsu added a reviewer: Intel Networking.

This looks correct to me. One of the folks actively working on the Intel networking drivers should take a look to make sure they're aware of it.

sys/dev/ixl/i40e_prototype.h
609–610 ↗(On Diff #75408)

Here's the other declaration.

This revision is now accepted and ready to land.Aug 10 2020, 4:38 PM

@lwhsu: Could you, please, remove the declaration in line 610 instead? The first occurrence is in a group of other LED functions.

In D25954#577171, @krzysztof.galazka_intel.com wrote:

@lwhsu: Could you, please, remove the declaration in line 610 instead? The first occurrence is in a group of other LED functions.

Of course, I was also thinking about that but ended with choosing to remove the first one because of their locations of the definitions in i40e_common.c.

This revision was automatically updated to reflect the committed changes.