It's submitted also to Forgejo: https://ron-dev.freebsd.org/FreeBSD/src/pulls/32, but I guess Phabricator is still preferred.

I'm testing that with GENERIC so with no RSS option. Without the patch both locally generated (iperf3) and forwarded (pkt-gen) UDP traffic is send using TX 0. I did a quick run on vanilla CURRENT with RSS enabled and it looks that in that case also only one TX queue is used, though it's not always queue 0. I haven't tried IPv6 yet.

• Add FW logging to features supported and enabled

on E610 adapters.

@kbowling, @erj - Bartek asked me to merge this patch, but I guess it's still requires your approval as mentors.

@emaste We had a miscommunication with QA team, but it is finally being tested. I'll commit the patch as soon as I get confirmation that we didn't break anything while porting from out-of-tree.

I wasn't able to find any additional info about a reason for this change, but I agree that 5+ years is enough time to assume it makes sense.

In D53089#1244212, @gallatin wrote:

In D53089#1244032, @adrian wrote:

what are you seeing? I remember ixl RSS being buggy!

A valid rss type set with a 0 flowid for connections nginx accepts. Not sure why ixl can't calculate a proper hash in that case, but it can be worked around by checking to see if the flowid (rss hash result) is valid.

See https://reviews.freebsd.org/D54442

The module will build only on 64-bit arch (amd64 and powerpc64 was already there, this patch adds arm64). I don't think it was ever tested on 32-bits, and I don't have too many spare cycles to look into that.

Actually it was submitted on Monday 12/08, so before the Bugzilla PR was opened, but since whole libxo support in devinfo was reverted I guess it's not needed anymore.

Enable building the driver as a module.

Hey, @imp @ktullavik_gmail.com, Could you please take a look at this?

@kbowling, @erj Could you please take a look? I'd like to commit this when we get a green light from validation team.

Thank you for your work on optimizing iflib!

Thank you! LGTM

Fix reviewers list.

Fix assertion condition. It should be the expected state, not the opposite.

Wake-on-Lan configuration is not available for VFs.

In D52782#1206718, @erj wrote:

Can you tell us what the hardware enhancements are? 👀

This file might be a collateral damage of splitting PF and VF drivers on Linux. We should have all definitions from this file in other places, but let me double check if there are no differences.