Page MenuHomeFreeBSD

ix(4): Run {mod,msf,mbx,fdir,phy}_task in if_update_admin_status
ClosedPublic

Authored by piotr.pietruszewski_intel.com on Dec 7 2018, 12:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 28, 11:26 PM
Unknown Object (File)
Fri, Nov 28, 4:18 PM
Unknown Object (File)
Fri, Nov 28, 12:29 PM
Unknown Object (File)
Thu, Nov 27, 5:47 PM
Unknown Object (File)
Wed, Nov 26, 7:47 AM
Unknown Object (File)
Tue, Nov 25, 11:12 AM
Unknown Object (File)
Thu, Nov 20, 8:21 PM
Unknown Object (File)
Thu, Nov 20, 8:20 PM

Details

Summary

This patch introduces adapter->task_requests register responsible for
recording requests for mod_task, msf_task, mbx_task, fdir_task and
phy_task calls. Instead of enqueueing these tasks with
GROUPTASK_ENQUEUE, handlers will be called directly from
ixgbe_if_update_admin_status() while holding ctx lock.

SIOCGIFXMEDIA ioctl() call reads adapter->media list. The list is
deleted and rewritten in ixgbe_handle_msf() task without holding ctx
lock. This change is needed to maintain data coherency when sharing
adapter info via ioctl() calls.

Patch co-authored by Krzysztof Galazka <krzysztof.galazka@intel.com>.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Dec 10 2018, 4:03 PM
This revision now requires review to proceed.Dec 11 2018, 2:00 PM
This revision is now accepted and ready to land.Jan 31 2019, 4:17 PM
This revision was automatically updated to reflect the committed changes.