HomeFreeBSD

ix(4): Run {mod,msf,mbx,fdir,phy}_task in if_update_admin_status

Description

ix(4): Run {mod,msf,mbx,fdir,phy}_task in if_update_admin_status

From Piotr:

This patch introduces adapter->task_requests register responsible for
recording requests for mod_task, msf_task, mbx_task, fdir_task and
phy_task calls. Instead of enqueueing these tasks with
GROUPTASK_ENQUEUE, handlers will be called directly from
ixgbe_if_update_admin_status() while holding ctx lock.

SIOCGIFXMEDIA ioctl() call reads adapter->media list. The list is
deleted and rewritten in ixgbe_handle_msf() task without holding ctx
lock. This change is needed to maintain data coherency when sharing
adapter info via ioctl() calls.

Patch co-authored by Krzysztof Galazka <krzysztof.galazka@intel.com>.

PR: 221317
Submitted by: Piotr Pietruszewski <piotr.pietruszewski@intel.com>
Reviewed by: sbruno@, IntelNetworking
Sponsored by: Intel Corporation
Differential Revision: https://reviews.freebsd.org/D18468

Details

Committed
erjJan 31 2019, 9:44 PM
Differential Revision
D18468: ix(4): Run {mod,msf,mbx,fdir,phy}_task in if_update_admin_status
Parents
rS343620: Don't set IFCAP_TXRTLMT during lagg_clone_create().
Branches
Unknown
Tags
Unknown