ixl(4): Fix handling data passed with ioctl from NVM update tool
ClosedPublic
Actions

Authored by kgalazka on Jan 11 2019, 8:57 AM.

Tags

None

Referenced Files

	F132508437: D18817.id53135.diff
	Fri, Oct 17, 12:29 PM

	F132508433: D18817.id.diff
	Fri, Oct 17, 12:29 PM

	F132508432: D18817.id52761.diff
	Fri, Oct 17, 12:29 PM

	F132461307: D18817.diff
	Fri, Oct 17, 3:19 AM

	Unknown Object (File)
	Tue, Oct 14, 6:22 AM

	Unknown Object (File)
	Tue, Oct 7, 1:15 PM

	Unknown Object (File)
	Sun, Sep 28, 6:18 PM

	Unknown Object (File)
	Sun, Sep 28, 6:14 AM

View All Files

Subscribers

erj

imp

Details

Reviewers

shurd
sbruno
jeffrey.e.pieper_intel.com

Group Reviewers

Intel Networking

Commits

rS344105: MFC: r343372
rS344104: MFC: r343372
rS343372: ixl(4): Fix handling data passed with ioctl from NVM update tool

Summary

Ensure that whole data buffer passed from NVM update tool
was copied in to kernel space and copied out back.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kgalazka created this revision.Jan 11 2019, 8:57 AM

Herald added a subscriber: ae. · View Herald TranscriptJan 11 2019, 8:57 AM

Harbormaster completed remote builds in B21923: Diff 52761.Jan 11 2019, 8:57 AM

Does anyone on this review know why this is necessary on 12.0+? I think we were supposed to be doing this in the first place, but I don't know why this stopped working.

jeffrey.e.pieper_intel.com accepted this revision.Jan 23 2019, 5:08 PM

This revision is now accepted and ready to land.Jan 23 2019, 5:08 PM

Closed by commit rS343372: ixl(4): Fix handling data passed with ioctl from NVM update tool (authored by erj). · Explain WhyJan 24 2019, 1:08 AM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptJan 24 2019, 1:08 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

ixl/

ixl_pf_main.c

69 lines

Diff 53135

View Options

head/sys/dev/ixl/ixl_pf_main.c

ixl(4): Fix handling data passed with ioctl from NVM update toolClosedPublicActions