em/igb: Properly re-arm link interrupt
AbandonedPublic
Actions

Authored by kgalazka on Sep 23 2019, 6:10 PM.

Tags

None

Referenced Files

	F150690724: D21769.diff
	Fri, Apr 3, 9:42 AM

	Unknown Object (File)
	Thu, Apr 2, 5:59 AM

	Unknown Object (File)
	Wed, Apr 1, 10:47 PM

	Unknown Object (File)
	Sat, Mar 28, 10:32 PM

	Unknown Object (File)
	Sat, Mar 28, 8:05 PM

	Unknown Object (File)
	Tue, Mar 24, 2:58 PM

	Unknown Object (File)
	Thu, Mar 19, 2:49 AM

	Unknown Object (File)
	Sun, Mar 15, 2:57 PM

Subscribers

Details

Reviewers

marius
shurd

Group Reviewers

Intel Networking

Summary

The link interrupt hasn't been re-enabled in the handler,
which caused that interface state changes were not reported
to the OS.

PR: 236724

Event: EuroBSD 2019 Hackathon
Sponsored by: Intel Corporation

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26657
Build 25031: arc lint + arc unit

Event Timeline

kgalazka created this revision.Sep 23 2019, 6:10 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 23 2019, 6:10 PM

Harbormaster completed remote builds in B26657: Diff 62478.Sep 23 2019, 6:10 PM

emaste added a subscriber: emaste.Sep 30 2019, 6:58 PM

I think this patch isn't entirely correct and complete; em_msix_link() should set EM_MSIX_LINK only for 82574 and em_if_update_admin_status() should only re-arm LSC interrupts if the driver takes advantage of autoclearing and, thus, uses MSI-X for such a device.
I've created D21924 with my version of the fix, which takes the above into account.

Hi, I just reported some feedback on PR 236724 you might be interested to check: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236724#c20 - was not sure on which of the differential reviews I should post to, this or D21712

Fixed with D21924 by marius

Revision Contents
Changeset List

Path

Size

sys/

dev/

e1000/

if_em.c

19 lines

Diff 62478

View Options

em/igb: Properly re-arm link interruptAbandonedPublicActions