Page MenuHomeFreeBSD
Differential D46061

iflib: Simplify iflib_legacy_setup
ClosedPublic
Actions

Authored by kgalazka on Jul 22 2024, 4:26 PM.
Tags
None
Referenced Files
F132822213: D46061.id143728.diff
Mon, Oct 20, 6:55 AM
Unknown Object (File)
Sat, Oct 18, 5:32 AM
Unknown Object (File)
Sat, Oct 18, 5:32 AM
Unknown Object (File)
Sat, Oct 18, 5:32 AM
Unknown Object (File)
Fri, Oct 17, 6:54 PM
Unknown Object (File)
Tue, Oct 7, 11:07 AM
Unknown Object (File)
Wed, Oct 1, 7:21 AM
Unknown Object (File)
Sep 15 2025, 7:51 PM
View All 92 Files
Subscribers
ae
glebius
imp
melifaro

Details

Reviewers
shurd
markj
Group Reviewers
iflib
Commits
rGfa0f7eefb92b: iflib: Simplify iflib_legacy_setup
rGd3c81ec4e90d: iflib: Simplify iflib_legacy_setup
rG36a001923836: iflib: Simplify iflib_legacy_setup
Summary

Follow the pattern from iflib_irq_alloc_generic function and use
iflib_fast_intr as a handler for RX only interrupts.

Also remove some intermediate variables and use consistent
way for referencing queue's structures.

Signed-off-by: Krzysztof Galazka <krzysztof.galazka@intel.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kgalazka created this revision.Jul 22 2024, 4:26 PM
Herald added a reviewer: shurd. · View Herald TranscriptJul 22 2024, 4:26 PM
Herald added a reviewer: iflib. · View Herald Transcript
Herald added subscribers: glebius, melifaro, ae, imp. · View Herald Transcript
kgalazka requested review of this revision.Jul 22 2024, 4:26 PM
kgalazka added a child revision: D46062: iflib(4): Replace admin taskqueue group with per-interface taskqueues.
Harbormaster completed remote builds in B58763: Diff 141230.Jul 22 2024, 4:26 PM
kgalazka added a reviewer: markj.Jul 22 2024, 4:32 PM
markj accepted this revision.Jul 22 2024, 10:39 PM
markj added inline comments.
sys/net/iflib.c
6443

This is safe because info->ifi_task != NULL, ok.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 25 2024, 8:34 PM
Closed by commit rG36a001923836: iflib: Simplify iflib_legacy_setup (authored by kgalazka, committed by Kevin Bowling <kbowling@FreeBSD.org>). · Explain Why
This revision was automatically updated to reflect the committed changes.
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG36a001923836: iflib: Simplify iflib_legacy_setup.
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGd3c81ec4e90d: iflib: Simplify iflib_legacy_setup.Oct 2 2024, 7:53 PM
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGfa0f7eefb92b: iflib: Simplify iflib_legacy_setup.Oct 2 2024, 7:56 PM

Revision Contents
Changeset List

PathSize
sys/
net/
16 lines

Diff 143728

View Options

sys/net/iflib.c

Loading...