Page MenuHomeFreeBSD

ix, ixv: Read msix_bar from device configuration
AcceptedPublic

Authored by piotr.pietruszewski_intel.com on Fri, Sep 6, 12:40 PM.

Details

Reviewers
marius
shurd
jhb
erj
Group Reviewers
Intel Networking
Summary

Instead of predicting MSI-X bar basing on mac type, read it from device
configuration.

This patch resolves PR 239704.

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 26306
Build 24785: arc lint + arc unit

Event Timeline

erj added a reviewer: jhb.Mon, Sep 9, 5:30 PM
erj added a subscriber: erj.

Is there a reason that we wouldn't do this for all of our drivers, instead of hardcoding the BAR index?

I agree with Eric, we should depend on the device to be configured properly, and push to get the images for the device updated if they're wrong.

jhb added a comment.Fri, Sep 13, 5:03 AM

If the BAR varies across devices, I think using pci_msix_table_bar is probably the simplest thing to do.

erj accepted this revision.Tue, Sep 17, 4:38 PM
This revision is now accepted and ready to land.Tue, Sep 17, 4:38 PM