Page MenuHomeFreeBSD

ix, ixv: Read msix_bar from device configuration
ClosedPublic

Authored by piotr.pietruszewski_intel.com on Sep 6 2019, 12:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 8, 4:43 PM
Unknown Object (File)
Sat, May 4, 2:46 PM
Unknown Object (File)
Fri, May 3, 1:31 AM
Unknown Object (File)
Tue, Apr 30, 6:09 AM
Unknown Object (File)
Thu, Apr 25, 8:56 PM
Unknown Object (File)
Tue, Apr 16, 3:37 AM
Unknown Object (File)
Apr 12 2024, 7:26 AM
Unknown Object (File)
Apr 10 2024, 2:34 AM

Details

Summary

Instead of predicting MSI-X bar basing on mac type, read it from device
configuration.

This patch resolves PR 239704.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26306
Build 24785: arc lint + arc unit

Event Timeline

erj added a subscriber: erj.

Is there a reason that we wouldn't do this for all of our drivers, instead of hardcoding the BAR index?

I agree with Eric, we should depend on the device to be configured properly, and push to get the images for the device updated if they're wrong.

If the BAR varies across devices, I think using pci_msix_table_bar is probably the simplest thing to do.

This revision is now accepted and ready to land.Sep 17 2019, 4:38 PM
This revision was automatically updated to reflect the committed changes.