Page MenuHomeFreeBSD

ice(4): Fix link speed after changing cable type
AcceptedPublic

Authored by kgalazka on Thu, Nov 6, 9:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 9, 9:42 PM
Unknown Object (File)
Fri, Nov 7, 5:49 PM
Unknown Object (File)
Fri, Nov 7, 4:08 PM
Unknown Object (File)
Fri, Nov 7, 1:46 PM
Unknown Object (File)
Fri, Nov 7, 11:48 AM
Unknown Object (File)
Fri, Nov 7, 2:19 AM
Unknown Object (File)
Fri, Nov 7, 2:18 AM
Unknown Object (File)
Thu, Nov 6, 9:47 PM
Subscribers

Details

Reviewers
erj
kbowling
Group Reviewers
Intel Networking
Summary

When interface was connected to a link partner with a cable
type limitting maximum supported speed, e.g. SFP+ cable
in 25G port, driver incorrectly saved a supported speed
as the user configured speed. This prevented interface
from using all supported speeds after switching cable to SFP28.
Link was established at 10G as supported by previously used
SFP+ cable. Don't set user requested speed unless actually
configured by an user, to allow automatic selection of highest
available speed. Only when user sets custom config
using advertise_speed sysctl save it and try
to apply after cable is changed.

Also don't save initial supported speeds if FW supports
reporting default PHY config.

Signed-off-by: Krzysztof Galazka <krzysztof.galazka@intel.com>

Sponsored by: Intel Corporation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 68452
Build 65335: arc lint + arc unit