Page MenuHomeFreeBSD
Differential D60371

iflib: Make the deferral test in iflib_txd_db_check() an early return
Needs ReviewPublic
Actions

Authored by rcm on Mon, Oct 5, 3:25 PM.
Tags
None
Referenced Files
F174742388: D60371.id188726.diff
Mon, Oct 5, 4:10 PM
F174742372: D60371.id188730.diff
Mon, Oct 5, 4:10 PM
F174742166: D60371.diff
Mon, Oct 5, 4:07 PM
F174739971: D60371.diff
Mon, Oct 5, 3:41 PM
Subscribers
ae
glebius
imp
kgalazka
melifaro

Details

Reviewers
gallatin
kbowling
shurd
Group Reviewers
iflib
Summary

Invert the test so the doorbell write is no longer nested inside the
conditional, and wrap its comments to 80 columns. Fix a typo in one of
them.

No functional change intended.

MFC after: 2 weeks
Sponsored by: Rubicon Communications, LLC ("Netgate")

Test Plan

No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

rcm created this revision.Mon, Oct 5, 3:25 PM
Herald added a reviewer: shurd. · View Herald TranscriptMon, Oct 5, 3:25 PM
Herald added a reviewer: iflib. · View Herald Transcript
Herald added subscribers: glebius, melifaro, ae, imp. · View Herald Transcript
rcm requested review of this revision.Mon, Oct 5, 3:25 PM
kgalazka added a subscriber: kgalazka.Mon, Oct 5, 3:36 PM
kgalazka added inline comments.
sys/net/iflib.c
3476

nit: extra space

rcm updated this revision to Diff 188730.Mon, Oct 5, 3:42 PM

removed extraneous space

rcm marked an inline comment as done.Mon, Oct 5, 3:42 PM

Revision Contents
Changeset List

PathSize
sys/
net/
37 lines

Diff 188730

View Options

sys/net/iflib.c

Loading...