iflib: Make the deferral test in iflib_txd_db_check() an early return
ClosedPublic
Actions

Authored by rcm on Mon, Oct 5, 3:25 PM.

Details

Reviewers

gallatin
kbowling
shurd

Group Reviewers

iflib

Commits

rGac24108dabca: iflib: Make the deferral test in iflib_txd_db_check() an early return

Summary

Invert the test so the doorbell write is no longer nested inside the
conditional, and wrap its comments to 80 columns. Fix a typo in one of
them.

No functional change intended.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Test Plan

No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

rcm created this revision.Mon, Oct 5, 3:25 PM

Herald added a reviewer: shurd. · View Herald TranscriptMon, Oct 5, 3:25 PM

Herald added a reviewer: iflib. · View Herald Transcript

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald Transcript

rcm requested review of this revision.Mon, Oct 5, 3:25 PM

kgalazka added a subscriber: kgalazka.Mon, Oct 5, 3:36 PM

kgalazka added inline comments.

sys/net/iflib.c
3476	nit: extra space

removed extraneous space

rcm marked an inline comment as done.Mon, Oct 5, 3:42 PM

rcm edited the summary of this revision. (Show Details)Mon, Oct 5, 6:31 PM

kbowling accepted this revision.Mon, Oct 5, 6:49 PM

This revision is now accepted and ready to land.Mon, Oct 5, 6:49 PM

Closed by commit rGac24108dabca: iflib: Make the deferral test in iflib_txd_db_check() an early return (authored by rcm). · Explain WhyMon, Oct 5, 6:53 PM

This revision was automatically updated to reflect the committed changes.

rcm added a commit: rGac24108dabca: iflib: Make the deferral test in iflib_txd_db_check() an early return.

Revision Contents
Changeset List

Path

Size

sys/

net/

iflib.c

37 lines

Diff 188730

View Options

iflib: Make the deferral test in iflib_txd_db_check() an early returnClosedPublicActions