Page MenuHomeFreeBSD

netinet6: Remove set but not used global variable in6_maxmtu
ClosedPublic

Authored by zlei on Mar 14 2025, 11:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 30, 1:20 AM
Unknown Object (File)
Wed, May 28, 6:17 AM
Unknown Object (File)
Wed, May 21, 10:13 AM
Unknown Object (File)
Wed, May 21, 3:40 AM
Unknown Object (File)
Tue, May 20, 4:14 PM
Unknown Object (File)
Mon, May 19, 2:34 PM
Unknown Object (File)
Apr 28 2025, 8:01 AM
Unknown Object (File)
Apr 27 2025, 1:30 PM
Subscribers

Details

Summary

This was introduced by the KAME project, but it appears to serve no purpose.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei requested review of this revision.Mar 14 2025, 11:53 AM
sys/netinet6/nd6_rtr.c
555–560

This can be simplified and avoids extra memory write if MTU didn't change.

		if (mtu <= maxmtu && ndi->linkmtu != mtu);
			ndi->linkmtu = mtu;
			rt_updatemtu(ifp);
		} else {
sys/netinet6/nd6_rtr.c
555–560

This can be simplified and avoids extra memory write if MTU didn't change.

Emm, then the else block

	nd6log((LOG_INFO, "%s: bogus mtu=%lu sent from %

may lost reporting when mtu > maxmtu && ndi->linkmtu == mtu .

sys/netinet6/nd6_rtr.c
555–560

may lost reporting when mtu > maxmtu && ndi->linkmtu == mtu

The above is wrong.

May falsely report bogus mtu when ndi->linkmtu == mtu.

Removed local var change.

This revision is now accepted and ready to land.Apr 10 2025, 3:29 PM