Page MenuHomeFreeBSD

netinet6: Remove set but not used global variable in6_maxmtu
ClosedPublic

Authored by zlei on Mar 14 2025, 11:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 12, 4:56 AM
Unknown Object (File)
Sun, Oct 12, 1:39 AM
Unknown Object (File)
Fri, Oct 10, 11:43 PM
Unknown Object (File)
Fri, Oct 10, 10:11 PM
Unknown Object (File)
Fri, Oct 10, 7:12 PM
Unknown Object (File)
Mon, Oct 6, 6:18 PM
Unknown Object (File)
Fri, Sep 26, 5:00 AM
Unknown Object (File)
Wed, Sep 24, 12:20 AM
Subscribers

Details

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei requested review of this revision.Mar 14 2025, 11:53 AM
sys/netinet6/nd6_rtr.c
555–560

This can be simplified and avoids extra memory write if MTU didn't change.

		if (mtu <= maxmtu && ndi->linkmtu != mtu);
			ndi->linkmtu = mtu;
			rt_updatemtu(ifp);
		} else {
sys/netinet6/nd6_rtr.c
555–560

This can be simplified and avoids extra memory write if MTU didn't change.

Emm, then the else block

	nd6log((LOG_INFO, "%s: bogus mtu=%lu sent from %

may lost reporting when mtu > maxmtu && ndi->linkmtu == mtu .

sys/netinet6/nd6_rtr.c
555–560

may lost reporting when mtu > maxmtu && ndi->linkmtu == mtu

The above is wrong.

May falsely report bogus mtu when ndi->linkmtu == mtu.

Removed local var change.

This revision is now accepted and ready to land.Apr 10 2025, 3:29 PM