Page MenuHomeFreeBSD

netinet6: Remove set but not used global variable in6_maxmtu
ClosedPublic

Authored by zlei on Mar 14 2025, 11:53 AM.
Tags
None
Referenced Files
F151260625: D49357.id152255.diff
Tue, Apr 7, 4:28 AM
Unknown Object (File)
Mon, Mar 30, 3:31 PM
Unknown Object (File)
Sat, Mar 28, 11:50 AM
Unknown Object (File)
Tue, Mar 24, 1:01 AM
Unknown Object (File)
Sun, Mar 22, 7:16 PM
Unknown Object (File)
Wed, Mar 18, 12:32 AM
Unknown Object (File)
Sat, Mar 14, 7:13 AM
Unknown Object (File)
Feb 8 2026, 10:20 AM
Subscribers

Details

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei requested review of this revision.Mar 14 2025, 11:53 AM
sys/netinet6/nd6_rtr.c
555–560

This can be simplified and avoids extra memory write if MTU didn't change.

		if (mtu <= maxmtu && ndi->linkmtu != mtu);
			ndi->linkmtu = mtu;
			rt_updatemtu(ifp);
		} else {
sys/netinet6/nd6_rtr.c
555–560

This can be simplified and avoids extra memory write if MTU didn't change.

Emm, then the else block

	nd6log((LOG_INFO, "%s: bogus mtu=%lu sent from %

may lost reporting when mtu > maxmtu && ndi->linkmtu == mtu .

sys/netinet6/nd6_rtr.c
555–560

may lost reporting when mtu > maxmtu && ndi->linkmtu == mtu

The above is wrong.

May falsely report bogus mtu when ndi->linkmtu == mtu.

Removed local var change.

This revision is now accepted and ready to land.Apr 10 2025, 3:29 PM