Page MenuHomeFreeBSD
Feed Advanced Search

Wed, Nov 13

zlei added a comment to D47529: netinet: handle blackhole routes.

And, with this change, it seems we no longer require nexthop to be loopback interface (V_lo) for blackhole / rejected routes.

Wed, Nov 13, 1:55 AM
zlei added a comment to D47534: Fix failure to add an interface prefix route when route with the same prefix is already presented in the routing table..

Is this a replacement of D46301 ?

Wed, Nov 13, 1:22 AM
zlei accepted D47533: qlnx: Convert recent changes to IfAPI.

Looks good to me.

Wed, Nov 13, 1:18 AM

Tue, Nov 12

zlei committed rGf9f470f72c87: ifnet(9): Document the IFF_PALLMULTI flag (authored by zlei).
ifnet(9): Document the IFF_PALLMULTI flag
Tue, Nov 12, 2:50 PM
zlei closed D47511: ifnet(9): Document the IFF_PALLMULTI flag.
Tue, Nov 12, 2:50 PM

Mon, Nov 11

zlei accepted D47506: inet.4: drop "experimetal use" from net0 and net240 descriptions.

Looks good to me.

Mon, Nov 11, 7:01 AM
zlei requested review of D47511: ifnet(9): Document the IFF_PALLMULTI flag.
Mon, Nov 11, 6:55 AM

Thu, Nov 7

zlei committed rGa30127914a3d: ndp: Bring back the -A option for the netlink implementation (authored by zlei).
ndp: Bring back the -A option for the netlink implementation
Thu, Nov 7, 11:27 PM
zlei committed rG0be04cb5cb98: ndp: Move the global variable repeat into struct ndp_opts (authored by zlei).
ndp: Move the global variable repeat into struct ndp_opts
Thu, Nov 7, 11:27 PM
zlei committed rG69d334e3bf2a: ocs_fc: Remove a stray semicolon (authored by zlei).
ocs_fc: Remove a stray semicolon
Thu, Nov 7, 4:34 PM
zlei committed rGed01695d05b9: LinuxKPI: Remove stray semicolons (authored by zlei).
LinuxKPI: Remove stray semicolons
Thu, Nov 7, 4:34 PM
zlei committed rG0a196c47ce95: makefs: Remove a stray semicolon (authored by zlei).
makefs: Remove a stray semicolon
Thu, Nov 7, 4:33 PM
zlei committed rG5bf5b3f42761: config: Remove a stray semicolon (authored by zlei).
config: Remove a stray semicolon
Thu, Nov 7, 4:33 PM
zlei committed rG13774c9a98c9: ndp: Remove a stray semicolon (authored by zlei).
ndp: Remove a stray semicolon
Thu, Nov 7, 4:33 PM
zlei committed rG5b8e4b1c123e: ifnet: Assert that we are assigning network stack correctly (authored by zlei).
ifnet: Assert that we are assigning network stack correctly
Thu, Nov 7, 4:33 PM
zlei added inline comments to D46759: release: add optional OCI images.
Thu, Nov 7, 4:29 PM
zlei committed rG0de672a59481: ndp: Bring back the -A option for the netlink implementation (authored by zlei).
ndp: Bring back the -A option for the netlink implementation
Thu, Nov 7, 4:09 AM
zlei committed rG54514cfa5a84: ndp: Move the global variable repeat into struct ndp_opts (authored by zlei).
ndp: Move the global variable repeat into struct ndp_opts
Thu, Nov 7, 4:09 AM
zlei added a comment to D39867: pvscsi: maximum target number is one less than number of targets.

Also encounter this issue on VMware Fusion (13.5.2). @yuripv May you please MFC this fix to stable/13 branch , or I can do that if no objections ?

Thu, Nov 7, 3:58 AM

Wed, Nov 6

zlei added a comment to D47384: setsockopt: Improve SO_SETFIB handling.

Do you hint that one listening socket can have multiple / change the fib number ? That sounds not possible

Well, what if we allow changing the fib number of listening socket, so filtering new connections based on the new fib number ?

Wed, Nov 6, 1:07 AM

Mon, Nov 4

zlei added a comment to D47384: setsockopt: Improve SO_SETFIB handling.

In fact, this probably does not go far enough. I'm not sure when it's useful to change the fibnum of a socket after creation time, but it's dangerous in general since the fibnum is also inherited by the inpcb.

What about multi-fib-aware applications? For example, nginx allows to specify a specific fib for each listening socket.

Mon, Nov 4, 8:18 AM

Fri, Nov 1

zlei added inline comments to D47315: socket: Export the FIB number of sockets.
Fri, Nov 1, 3:51 PM
zlei accepted D47316: sockstat: Add a -f option to show FIB numbers of sockets.
Fri, Nov 1, 7:14 AM
zlei added inline comments to D47315: socket: Export the FIB number of sockets.
Fri, Nov 1, 7:00 AM
zlei accepted D47315: socket: Export the FIB number of sockets.

Looks good to me.

Fri, Nov 1, 6:57 AM

Thu, Oct 31

zlei committed rGb6d4e3bee350: ndp: Bring back the -A option for the netlink implementation (authored by zlei).
ndp: Bring back the -A option for the netlink implementation
Thu, Oct 31, 4:34 PM
zlei committed rG12c04071cf18: ndp: Move the global variable repeat into struct ndp_opts (authored by zlei).
ndp: Move the global variable repeat into struct ndp_opts
Thu, Oct 31, 4:34 PM
zlei closed D47234: ndp: Bring back -A option for the netlink implementation.
Thu, Oct 31, 4:34 PM
zlei closed D47233: ndp: Move the option repeat to struct ndp_opts.
Thu, Oct 31, 4:34 PM
zlei added a comment to D47314: net/if_media.c: avoid if_bge attach panic on Supermicro H13SSL-N.
In D47314#1079145, @kib wrote:

This is indeed a workaround, I remember fixing something similar for ports' variant of if_re. The fix was to move the ether_ifattach() after the media structures are initialized,
https://github.com/alexdupre/rtl_bsd_drv/commit/2a97cc982d0362b69040d1c849f697ff61e37106

I did not looked at the bge code to confirm that it is the case.

Thu, Oct 31, 10:09 AM
zlei committed rG1821145f28e9: tcp cc: Remove a stray semicolon (authored by zlei).
tcp cc: Remove a stray semicolon
Thu, Oct 31, 4:44 AM
zlei committed rG1d8eda2e3255: mpi3mr: Remove a stray semicolon (authored by zlei).
mpi3mr: Remove a stray semicolon
Thu, Oct 31, 4:44 AM
zlei committed rG02e61e1d9e02: ocs_fc: Remove a stray semicolon (authored by zlei).
ocs_fc: Remove a stray semicolon
Thu, Oct 31, 4:44 AM
zlei committed rGe96a62ea658e: mana: Remove stray semicolons (authored by zlei).
mana: Remove stray semicolons
Thu, Oct 31, 4:44 AM
zlei committed rG88971439fbe0: enic: Remove a stray semicolon (authored by zlei).
enic: Remove a stray semicolon
Thu, Oct 31, 4:44 AM
zlei committed rG5942658cf357: LinuxKPI: Remove stray semicolons (authored by zlei).
LinuxKPI: Remove stray semicolons
Thu, Oct 31, 4:44 AM
zlei committed rG4d2d1e824bc5: arm64: rockchip: Remove a stray semicolon (authored by zlei).
arm64: rockchip: Remove a stray semicolon
Thu, Oct 31, 4:44 AM
zlei committed rG30e256e1faf4: makefs: Remove a stray semicolon (authored by zlei).
makefs: Remove a stray semicolon
Thu, Oct 31, 4:44 AM
zlei committed rG57af3009cb29: config: Remove a stray semicolon (authored by zlei).
config: Remove a stray semicolon
Thu, Oct 31, 4:44 AM
zlei committed rG00fa80275f34: ndp: Remove a stray semicolon (authored by zlei).
ndp: Remove a stray semicolon
Thu, Oct 31, 4:44 AM
zlei committed rG2f3c87296cc7: ifnet: Assert that we are assigning network stack correctly (authored by zlei).
ifnet: Assert that we are assigning network stack correctly
Thu, Oct 31, 4:44 AM
zlei committed rG01f4a503eb0f: ifconfig: Fix wrong indentation for the status of pfsync(4) (authored by zlei).
ifconfig: Fix wrong indentation for the status of pfsync(4)
Thu, Oct 31, 4:44 AM

Wed, Oct 30

zlei added inline comments to D32719: udp_input: remove a BSD stack relict.
Wed, Oct 30, 8:37 AM
zlei added a comment to D40766: ena: Fix driver unload crash.

Landed as c59a5fbd8a2e (ena: Fix driver unload crash).

Wed, Oct 30, 7:50 AM
zlei requested review of D47335: sppp: Fix getting wrong spppreq cmd from ioctl.
Wed, Oct 30, 7:21 AM
zlei added a comment to D47332: sysctl: Add missing CTLFLAG_PRISON to security.jail.children.*.

Another point is how to deal with sysctl which are "per jail" and vnet-related as well. I guess, they could end up with both flags?

Wed, Oct 30, 2:30 AM
zlei added a comment to D47332: sysctl: Add missing CTLFLAG_PRISON to security.jail.children.*.

sysctl: Add missing CTLFLAG_PRISON to security.jail.children.*

Wed, Oct 30, 2:28 AM
zlei accepted D47332: sysctl: Add missing CTLFLAG_PRISON to security.jail.children.*.

This looks good to me.

Wed, Oct 30, 2:22 AM
zlei added a reviewer for D47332: sysctl: Add missing CTLFLAG_PRISON to security.jail.children.*: jamie.
Wed, Oct 30, 2:21 AM

Tue, Oct 29

zlei closed D47107: sysctl: Add flags to filter jail prison and vnet variables.
Tue, Oct 29, 11:28 AM
zlei committed rG5ec83c660aca: sysctl: Add flags to filter jail prison and vnet variables (authored by zlei).
sysctl: Add flags to filter jail prison and vnet variables
Tue, Oct 29, 11:28 AM

Mon, Oct 28

zlei added inline comments to D47234: ndp: Bring back -A option for the netlink implementation.
Mon, Oct 28, 9:00 AM
zlei updated the diff for D47107: sysctl: Add flags to filter jail prison and vnet variables.

Added -J flag to filter jail prison variables.

Mon, Oct 28, 8:23 AM

Fri, Oct 25

zlei committed rGbbd018d0aaaf: ping(8): Fix typo in ping6.c (authored by Hao-Yu Hou <howard.hou.fan@elsa.cs.nthu.edu.tw>).
ping(8): Fix typo in ping6.c
Fri, Oct 25, 3:59 PM
zlei committed rG2a0d3dd35197: sysctl(8): Fix typo in comment (authored by Hao-Yu Hou <howard.hou.fan@elsa.cs.nthu.edu.tw>).
sysctl(8): Fix typo in comment
Fri, Oct 25, 3:59 PM
zlei added a comment to D47107: sysctl: Add flags to filter jail prison and vnet variables.

This change is focusing on VNET variables, but is open for -J ( CTLFLAG_PRISON ) if requested.

Fri, Oct 25, 3:53 PM
zlei updated the diff for D47107: sysctl: Add flags to filter jail prison and vnet variables.

Use -V instead. Added Xr jail 8 .

Fri, Oct 25, 3:50 PM

Thu, Oct 24

zlei added inline comments to D47107: sysctl: Add flags to filter jail prison and vnet variables.
Thu, Oct 24, 4:53 PM
zlei added inline comments to D47107: sysctl: Add flags to filter jail prison and vnet variables.
Thu, Oct 24, 4:50 PM
zlei added a comment to D47107: sysctl: Add flags to filter jail prison and vnet variables.

Add network and Jails people if they have interests on this.

Thu, Oct 24, 3:59 PM
zlei added reviewers for D47107: sysctl: Add flags to filter jail prison and vnet variables: network, Jails.
Thu, Oct 24, 3:56 PM
zlei added a comment to D47234: ndp: Bring back -A option for the netlink implementation.
In D47234#1077261, @kp wrote:

It's not as straightforward for '-A' as it'd be for other options, but we should look into writing a test case for this too.
Known bugs are an obvious candidate for test cases after all.

Thu, Oct 24, 3:55 PM
zlei added a comment to D46794: axgbe: Fix setting promisc mode.

Is that specific to FreeBSD only ? I do not see this workaround in Linux driver https://github.com/torvalds/linux/blob/master/drivers/net/ethernet/amd/xgbe/xgbe-dev.c#L2855 .

I don't know for sure, but chances are this issue has never been seen on Linux given the low adoption.

Thu, Oct 24, 3:48 PM
zlei committed rG2f395cfda8b5: tcp cc: Remove a stray semicolon (authored by zlei).
tcp cc: Remove a stray semicolon
Thu, Oct 24, 3:08 PM
zlei committed rG36756195a342: ocs_fc: Remove a stray semicolon (authored by zlei).
ocs_fc: Remove a stray semicolon
Thu, Oct 24, 3:08 PM
zlei committed rG86a2c910c05c: mpi3mr: Remove a stray semicolon (authored by zlei).
mpi3mr: Remove a stray semicolon
Thu, Oct 24, 3:08 PM
zlei committed rG6ccf4f4071c5: mana: Remove stray semicolons (authored by zlei).
mana: Remove stray semicolons
Thu, Oct 24, 3:08 PM
zlei committed rG75ff90814aec: enic: Remove a stray semicolon (authored by zlei).
enic: Remove a stray semicolon
Thu, Oct 24, 3:08 PM
zlei committed rGb4856b8e9d87: LinuxKPI: Remove stray semicolons (authored by zlei).
LinuxKPI: Remove stray semicolons
Thu, Oct 24, 3:07 PM
zlei committed rG88b71d1fe054: arm64: rockchip: Remove a stray semicolon (authored by zlei).
arm64: rockchip: Remove a stray semicolon
Thu, Oct 24, 3:07 PM
zlei committed rG56b17de1e836: makefs: Remove a stray semicolon (authored by zlei).
makefs: Remove a stray semicolon
Thu, Oct 24, 3:07 PM
zlei committed rGd96ba5a62365: config: Remove a stray semicolon (authored by zlei).
config: Remove a stray semicolon
Thu, Oct 24, 3:07 PM

Tue, Oct 22

zlei accepted D47231: netstat: convert routing statistics to a sysctl.

Looks good to me.

Tue, Oct 22, 1:59 PM
zlei added inline comments to D47234: ndp: Bring back -A option for the netlink implementation.
Tue, Oct 22, 11:33 AM
zlei added a comment to D47233: ndp: Move the option repeat to struct ndp_opts.

A following fix for the netlink based implementation requires this refactoring

Tue, Oct 22, 11:31 AM
zlei requested review of D47234: ndp: Bring back -A option for the netlink implementation.
Tue, Oct 22, 11:31 AM
zlei requested review of D47233: ndp: Move the option repeat to struct ndp_opts.
Tue, Oct 22, 11:20 AM
zlei added inline comments to D47231: netstat: convert routing statistics to a sysctl.
Tue, Oct 22, 6:14 AM
zlei closed D46982: ifnet: Assert that we are assigning network stack correctly.
Tue, Oct 22, 4:34 AM
zlei committed rGd1d839d0b593: ifnet: Assert that we are assigning network stack correctly (authored by zlei).
ifnet: Assert that we are assigning network stack correctly
Tue, Oct 22, 4:34 AM
Herald added a reviewer for D4295: Add driver backpressure: iflib.
Tue, Oct 22, 1:54 AM · transport

Mon, Oct 21

zlei added a comment to D46794: axgbe: Fix setting promisc mode.

Just to comment on the unconditional promisc mode initialization, this is shown in more detail here: https://github.com/freebsd/freebsd-src/blob/main/sys/dev/axgbe/xgbe-dev.c#L2032-L2036.

Mon, Oct 21, 4:04 PM
zlei updated the diff for D45727: bpf: Detach descriptors on interface departure event.

Rebased onto latest main.

Mon, Oct 21, 3:12 AM
zlei added inline comments to D45727: bpf: Detach descriptors on interface departure event.
Mon, Oct 21, 2:59 AM

Sun, Oct 20

zlei committed rGf6711b97b228: netstat.1: Clarify -d argument (authored by bram0007_gmail.com).
netstat.1: Clarify -d argument
Sun, Oct 20, 3:04 PM
zlei committed rGedbeda6b7594: netstat.1: Clarify -d argument (authored by bram0007_gmail.com).
netstat.1: Clarify -d argument
Sun, Oct 20, 3:02 PM
zlei committed rG1c95ec17cae2: ifconfig: Fix wrong indentation for the status of pfsync(4) (authored by zlei).
ifconfig: Fix wrong indentation for the status of pfsync(4)
Sun, Oct 20, 2:07 PM
zlei closed D47112: ifconfig: Fix wrong indent for the status of pfsync(4).
Sun, Oct 20, 2:07 PM
zlei committed rG03f7680517c8: if_enc(4): Use new KPI to create enc interface (authored by zlei).
if_enc(4): Use new KPI to create enc interface
Sun, Oct 20, 1:44 PM

Sat, Oct 19

zlei added a comment to D45727: bpf: Detach descriptors on interface departure event.

I'd like to push this to main and MFC to stable/14. Any objections ?

Sat, Oct 19, 2:40 AM
zlei added a comment to D47107: sysctl: Add flags to filter jail prison and vnet variables.

My personal usage is get vnet tunables via the combination of -J and -T. This has been in my local working tree for quite a long time, mainly to support working on D39638 .

Sat, Oct 19, 2:39 AM
zlei added inline comments to D47174: bus: Set the current VNET in device_attach().
Sat, Oct 19, 1:31 AM
zlei accepted D47174: bus: Set the current VNET in device_attach().

This should also fix https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275381 . See also D42678 .

Sat, Oct 19, 1:20 AM

Thu, Oct 17

zlei committed rG17120e4bc3e6: ndp: Remove a stray semicolon (authored by zlei).
ndp: Remove a stray semicolon
Thu, Oct 17, 1:11 PM

Oct 15 2024

zlei updated the diff for D47107: sysctl: Add flags to filter jail prison and vnet variables.

Address @Jose 's comment.

Oct 15 2024, 4:53 AM
zlei requested review of D47112: ifconfig: Fix wrong indent for the status of pfsync(4).
Oct 15 2024, 4:48 AM
zlei added a reverting change for rG09f6ff4f1a47: iflib(9): Add support for cloning pseudo interfaces: rGf1587b9c7844: iflib: Make iflib_stop() static.
Oct 15 2024, 4:41 AM
zlei committed rGf1587b9c7844: iflib: Make iflib_stop() static (authored by zlei).
iflib: Make iflib_stop() static
Oct 15 2024, 4:40 AM

Oct 14 2024

zlei requested review of D47107: sysctl: Add flags to filter jail prison and vnet variables.
Oct 14 2024, 2:03 PM
zlei accepted D46372: ena: Fix leaking ifmedia resources on detach.
Oct 14 2024, 1:05 PM