linux: Make the macro LINUX_IOCTL_SET public
ClosedPublic
Actions

Authored by zlei on Oct 17 2025, 9:44 AM.

Details

Reviewers

Commits

rG0a2fb63b4954: mrsas: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
rGd12ce84b0d33: mfi: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
rGcb0116af7ac7: ipmi: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
rGff29e5bc53e6: aacraid: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
rGdb1844a0e1bc: aac: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
rG8350f46d9808: sgx: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
rG790c27317ec1: linux: Make the macro LINUX_IOCTL_SET public

Summary

There're some drivers want to register and unregister linux ioctl
handler. Move the macro LINUX_IOCTL_SET from tdfx_linux.h to
linux_ioctl.h so that other drivers can benefit it.

While here, rename the declaration of linux ioctl function to be
consistent with the name of the handler.

MFC after:      2 weeks

Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Oct 17 2025, 9:44 AM

Herald added a subscriber: imp. · View Herald TranscriptOct 17 2025, 9:44 AM

zlei requested review of this revision.Oct 17 2025, 9:44 AM

Nice cleanup.

sys/compat/linux/linux_ioctl.h
829	I don't think the comment needs to be kept.

This revision is now accepted and ready to land.Fri, Oct 17, 12:40 PM

zlei added inline comments.Sat, Oct 18, 3:43 PM

sys/compat/linux/linux_ioctl.h
829	I'm not sure whether that comment is related to license / credential or not, so I kept it as is.

markj added inline comments.Sun, Oct 19, 2:01 PM

sys/compat/linux/linux_ioctl.h
829	I don't think so, otherwise there should be some formal copyright statement. Maybe it's useful for the comment to explain what the macro does, but it's weird to mention the author. See commit f16178e0bba81c32b1f4fba310c7d0f2756aca85 for a similar example.