Differential D53158

linux: Make the macro LINUX_IOCTL_SET public
ClosedPublic
Actions

Authored by zlei on Oct 17 2025, 9:44 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jan 25, 4:31 AM

	Unknown Object (File)
	Mon, Jan 19, 8:41 AM

	Unknown Object (File)
	Mon, Jan 12, 2:22 PM

	Unknown Object (File)
	Mon, Jan 12, 2:18 PM

	Unknown Object (File)
	Mon, Jan 12, 1:22 PM

	Unknown Object (File)
	Mon, Jan 12, 1:11 PM

	Unknown Object (File)
	Sat, Jan 10, 5:57 PM

	Unknown Object (File)
	Dec 8 2025, 5:54 PM

View All 33 Files

Subscribers

Details

Reviewers

Commits

rG7621b6eded12: mrsas: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
rG44dfede815d8: mfi: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
rG9280324325f3: ipmi: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
rG352c1e0f172a: aacraid: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
rGd6bc614eac5a: aac: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
rGe36e17552cdf: sgx: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
rG5004b384a657: linux: Make the macro LINUX_IOCTL_SET public
rG087e77b52399: linux: Make the macro LINUX_IOCTL_SET public
rG270b9f2a4888: mfi: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
rG3aa4ae2006b5: mrsas: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
rGe5d4314fce5a: aacraid: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
rG0b0ddadf39f6: ipmi: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
rG7e9fe8e6a196: aac: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
rG957babc65d9f: sgx: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
rG0a2fb63b4954: mrsas: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
rGd12ce84b0d33: mfi: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
rGcb0116af7ac7: ipmi: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
rGff29e5bc53e6: aacraid: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
rGdb1844a0e1bc: aac: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
rG8350f46d9808: sgx: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler
rG790c27317ec1: linux: Make the macro LINUX_IOCTL_SET public

Summary

There're some drivers want to register and unregister linux ioctl
handler. Move the macro LINUX_IOCTL_SET from tdfx_linux.h to
linux_ioctl.h so that other drivers can benefit it.

While here, rename the declaration of linux ioctl function to be
consistent with the name of the handler.

MFC after:      2 weeks

Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Oct 17 2025, 9:44 AM

Herald added a subscriber: imp. · View Herald TranscriptOct 17 2025, 9:44 AM

zlei requested review of this revision.Oct 17 2025, 9:44 AM

Nice cleanup.

sys/compat/linux/linux_ioctl.h
829	I don't think the comment needs to be kept.

This revision is now accepted and ready to land.Oct 17 2025, 12:40 PM

zlei added inline comments.Oct 18 2025, 3:43 PM

sys/compat/linux/linux_ioctl.h
829	I'm not sure whether that comment is related to license / credential or not, so I kept it as is.

markj added inline comments.Oct 19 2025, 2:01 PM

sys/compat/linux/linux_ioctl.h
829	I don't think so, otherwise there should be some formal copyright statement. Maybe it's useful for the comment to explain what the macro does, but it's weird to mention the author. See commit f16178e0bba81c32b1f4fba310c7d0f2756aca85 for a similar example.

Closed by commit rG790c27317ec1: linux: Make the macro LINUX_IOCTL_SET public (authored by zlei). · Explain WhyOct 20 2025, 4:29 AM

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rG790c27317ec1: linux: Make the macro LINUX_IOCTL_SET public.

zlei added a commit: rG8350f46d9808: sgx: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler.

zlei added a commit: rGdb1844a0e1bc: aac: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler.

zlei added a commit: rGff29e5bc53e6: aacraid: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler.

zlei added a commit: rGcb0116af7ac7: ipmi: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler.

zlei added a commit: rGd12ce84b0d33: mfi: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler.

zlei added a commit: rG0a2fb63b4954: mrsas: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler.

zlei marked 2 inline comments as done.Oct 20 2025, 4:32 AM

zlei added inline comments.

sys/compat/linux/linux_ioctl.h
829	Removed the comment in final commit.

zlei marked an inline comment as done.Sat, Jan 31, 5:05 PM

zlei added a commit: rG957babc65d9f: sgx: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler.

zlei added a commit: rG7e9fe8e6a196: aac: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler.

zlei added a commit: rGe5d4314fce5a: aacraid: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler.

zlei added a commit: rG0b0ddadf39f6: ipmi: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler.

zlei added a commit: rG270b9f2a4888: mfi: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler.

zlei added a commit: rG3aa4ae2006b5: mrsas: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler.

zlei added a commit: rG087e77b52399: linux: Make the macro LINUX_IOCTL_SET public.Sat, Jan 31, 5:10 PM

zlei added a commit: rG5004b384a657: linux: Make the macro LINUX_IOCTL_SET public.Mon, Feb 2, 5:25 PM

zlei added a commit: rGe36e17552cdf: sgx: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler.

zlei added a commit: rGd6bc614eac5a: aac: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler.

zlei added a commit: rG352c1e0f172a: aacraid: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler.

zlei added a commit: rG9280324325f3: ipmi: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler.

zlei added a commit: rG44dfede815d8: mfi: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler.

zlei added a commit: rG7621b6eded12: mrsas: Migrate to use macro LINUX_IOCTL_SET to register linux ioctl handler.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linux/

12 lines

dev/

tdfx/

12 lines

2 lines

Diff 164566

sys/compat/linux/linux_ioctl.h

Loading...

sys/dev/tdfx/tdfx_linux.h

Loading...

sys/dev/tdfx/tdfx_linux.c

Loading...