Page MenuHomeFreeBSD
Differential D53173

imgact: Mark brandinfo and note structures as const
ClosedPublic
Actions

Authored by zlei on Fri, Oct 17, 5:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 18, 5:27 AM
Unknown Object (File)
Sat, Oct 18, 5:27 AM
Unknown Object (File)
Fri, Oct 17, 9:36 PM
Unknown Object (File)
Fri, Oct 17, 8:44 PM
Unknown Object (File)
Fri, Oct 17, 7:13 PM
Unknown Object (File)
Fri, Oct 17, 7:12 PM
Subscribers
imp
jhibbits
jrtc27
riscv

Details

Reviewers
markj
kib
emaste
olce
andrew
Commits
rG301e6c47127d: imgact: Mark brandinfo and note structures as const
Summary

No functional change intended.




MFC after:      2 weeks

MFC with:       80336636b6b9f7a3bdad007c400e85eae017d2a2
Diff Detail
Repository 
rG FreeBSD src repository 
Lint 
Lint Not Applicable
 
Unit 
Tests Not Applicable
 
Event Timeline
zlei created this revision.Fri, Oct 17, 5:30 PM
Herald added a reviewer: andrew.  ·  View Herald TranscriptFri, Oct 17, 5:30 PM
Herald added subscribers: riscv, jhibbits, imp.  ·  View Herald Transcript
zlei requested review of this revision.Fri, Oct 17, 5:30 PM
zlei added a comment.Fri, Oct 17, 5:35 PM
This is for other architectures, i386, arm, powerpc and riscv.



Another brandnotes to be constified are freebsd_brandnote and kfreebsd_brandnote.



Discussed with Mark. Posted to review to see if I missed anything.
kib added inline comments.Fri, Oct 17, 10:54 PM
sys/sys/imgact_elf.h


90
To add more to the const fest.
jrtc27 added a subscriber: jrtc27.Fri, Oct 17, 10:56 PM
jrtc27 added inline comments.
sys/sys/imgact_elf.h


90
None of the other fields are const though?
kib accepted this revision.Fri, Oct 17, 11:10 PM
kib added inline comments.
sys/sys/imgact_elf.h


90
This is why I am talking about fest.
This revision is now accepted and ready to land.Fri, Oct 17, 11:10 PM
Closed by commit rG301e6c47127d: imgact: Mark brandinfo and note structures as const (authored by zlei).  ·  Explain WhySat, Oct 18, 4:13 PM
This revision was automatically updated to reflect the committed changes.
zlei added a commit: rG301e6c47127d: imgact: Mark brandinfo and note structures as const.
zlei marked 2 inline comments as done.Sat, Oct 18, 4:17 PM
zlei added inline comments.
sys/sys/imgact_elf.h


90
const header_supported is now in final commit.
Revision Contents
Changeset List
PathSize
sys/
arm/
arm/
4 lines
i386/
i386/
12 lines
linux/
12 lines
kern/
4 lines
powerpc/
powerpc/
8 lines
12 lines
riscv/
riscv/
4 lines
sys/
6 lines
Diff 164501
View Options
sys/arm/arm/elf_machdep.c
Loading...
View Options
sys/i386/i386/elf_machdep.c
Loading...
View Options
sys/i386/linux/linux_sysvec.c
Loading...
View Options
sys/kern/imgact_elf.c
Loading...
View Options
sys/powerpc/powerpc/elf32_machdep.c
Loading...
View Options
sys/powerpc/powerpc/elf64_machdep.c
Loading...
View Options
sys/riscv/riscv/elf_machdep.c
Loading...
View Options
sys/sys/imgact_elf.h
Loading...