I'm not getting this change. The kernel build option RSS is not enabled by default. Is this change want to enable a variant RSS when RSS is not enabled in the kernel ?

sys/dev/liquidio/lio_rss.c
79	The function `rss_gethashconfig()` appears to be only available when the build option `RSS` is present.

In D53101#1214510, @zlei wrote:

I'm not getting this change. The kernel build option RSS is not enabled by default. Is this change want to enable a variant RSS when RSS is not enabled in the kernel ?

Ahh, I missed D53089 .

In D53101#1214513, @zlei wrote:

In D53101#1214510, @zlei wrote:

I'm not getting this change. The kernel build option RSS is not enabled by default. Is this change want to enable a variant RSS when RSS is not enabled in the kernel ?

Ahh, I missed D53089 .

Yes, I'm sorry about that. That one exposes RSS hashing. The goal is to get to https://reviews.freebsd.org/D53104, which uses the fact that all nics are using the same algo and key to do software hashing of outgoing connections when they are born in order to get consistent hashing such that a connection always uses the same egress nic and queue. This is the first time I've used the git-arc feature to review a series of changes, and I'm afraid I did not do a great job of composing this review

I spent some time to learn the FreeBSD's RSS design. I do not have hardware to test, but the change looks good to me.

This revision is now accepted and ready to land.Oct 24 2025, 4:03 PM

Closed by commit rG5a94c2e89f6a: lio: use newly exposed RSS hash key API rather than ad-hoc hashing (authored by gallatin). · Explain WhySat, Nov 22, 2:31 PM

This revision was automatically updated to reflect the committed changes.

gallatin added a commit: rG5a94c2e89f6a: lio: use newly exposed RSS hash key API rather than ad-hoc hashing.