Differential D51064

pfsync: Allocate and initialize buckets before attaching the interface
ClosedPublic
Actions

Authored by zlei on Jun 26 2025, 2:04 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Feb 9, 7:14 AM

	Unknown Object (File)
	Thu, Feb 5, 1:55 AM

	Unknown Object (File)
	Sun, Feb 1, 9:47 PM

	Unknown Object (File)
	Sun, Feb 1, 8:09 AM

	Unknown Object (File)
	Fri, Jan 30, 4:06 AM

	Unknown Object (File)
	Jan 27 2026, 2:43 AM

	Unknown Object (File)
	Jan 20 2026, 12:15 PM

	Unknown Object (File)
	Jan 19 2026, 6:03 PM

View All 46 Files

Subscribers

vegeta_tuxpowered.net

Details

Reviewers

Commits

rG0a5e8108bf20: pfsync: Allocate and initialize buckets before attaching the interface
rG8cc376735c65: pfsync: Allocate and initialize buckets before attaching the interface
rGedc307eca9a9: pfsync: Allocate and initialize buckets before attaching the interface

Summary

This prevents a potential race that the ioctl threads see NULL or
uninitialized buckets.

Fixes: 4fc65bcbe3fb pfsync: Performance improvement
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Jun 26 2025, 2:04 PM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptJun 26 2025, 2:04 PM

zlei requested review of this revision.Jun 26 2025, 2:04 PM

kp accepted this revision.Jun 27 2025, 11:50 AM

This revision is now accepted and ready to land.Jun 27 2025, 11:50 AM

Closed by commit rGedc307eca9a9: pfsync: Allocate and initialize buckets before attaching the interface (authored by zlei). · Explain WhyJun 28 2025, 3:49 PM

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rGedc307eca9a9: pfsync: Allocate and initialize buckets before attaching the interface.

zlei added a commit: rG8cc376735c65: pfsync: Allocate and initialize buckets before attaching the interface.Jul 7 2025, 10:09 AM

zlei added a commit: rG0a5e8108bf20: pfsync: Allocate and initialize buckets before attaching the interface.Jul 8 2025, 10:06 AM

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

33 lines

Diff 157724

sys/netpfil/pf/if_pfsync.c

Loading...