Page MenuHomeFreeBSD

ifnet: Integrate if_unroute() into if_down()
ClosedPublic

Authored by zlei on Mar 14 2025, 11:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 1:55 AM
Unknown Object (File)
Fri, Oct 10, 4:21 PM
Unknown Object (File)
Fri, Oct 10, 2:20 PM
Unknown Object (File)
Wed, Oct 8, 12:24 AM
Unknown Object (File)
Mon, Sep 29, 11:14 AM
Unknown Object (File)
Sat, Sep 27, 5:24 AM
Unknown Object (File)
Thu, Sep 25, 9:55 PM
Unknown Object (File)
Wed, Sep 24, 1:21 AM
Subscribers

Details

Summary

if_unroute() is static since 2004 and is not used anywhere except for
if_down().

This also makes it easier to grep by the pattern if_flags &= ~IFF_UP.

No functional change intended.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei requested review of this revision.Mar 14 2025, 11:48 AM

Thanks!

I have only light concerns with aggressive MFC plan on refactoring changes. Sometimes bugs sneak into refactorings that seems to be innocent. Whether to MFC or not is almost always is up to decision of merging committer. My personal take is that I would MFC refactoring changes only if they are a prerequisite for a following bugfix or a new driver/module that goes to a stable branch.

This revision is now accepted and ready to land.Mar 14 2025, 4:47 PM

Thanks!

I have only light concerns with aggressive MFC plan on refactoring changes. Sometimes bugs sneak into refactorings that seems to be innocent.

Yeah, I think I have checked that carefully. For this case, I checked the usage of if_unroute() from -current to stable/8.

Whether to MFC or not is almost always is up to decision of merging committer. My personal take is that I would MFC refactoring changes only if they are a prerequisite for a following bugfix or a new driver/module that goes to a stable branch.

Valid point. Well I tend to MFC if possible, mainly to reduce the drift between stable branches, and it is easier to filter out critical changes between branches.

Anyway I'll do that carefully.

This revision was automatically updated to reflect the committed changes.