Page MenuHomeFreeBSD
Differential D50491

bnxt: Fix the request length specified in bnxt_hwrm_func_backing_store_cfg
ClosedPublic
Actions

Authored by markj on May 23 2025, 5:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 10, 3:45 PM
Unknown Object (File)
Fri, Oct 10, 3:45 PM
Unknown Object (File)
Fri, Oct 10, 3:45 PM
Unknown Object (File)
Fri, Oct 10, 9:35 AM
Unknown Object (File)
Mon, Sep 29, 10:45 AM
Unknown Object (File)
Sun, Sep 28, 12:29 PM
Unknown Object (File)
Thu, Sep 25, 12:28 PM
Unknown Object (File)
Tue, Sep 23, 10:54 PM
View All 28 Files
Subscribers
imp

Details

Reviewers
zlei
shurd
sreekanth.reddy_broadcom.com
imp
sumit.saxena_broadcom.com
Commits
rG87691082d860: bnxt: Fix the request length in bnxt_hwrm_func_backing_store_cfg()
rG20bb3d7d500b: bnxt: Fix the request length in bnxt_hwrm_func_backing_store_cfg()
rG5ca390f03bc6: bnxt: Fix the request length in bnxt_hwrm_func_backing_store_cfg()
Summary

PR: 286720

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.May 23 2025, 5:01 PM
Herald added a reviewer: shurd. · View Herald TranscriptMay 23 2025, 5:01 PM
Herald added a subscriber: imp. · View Herald Transcript
markj requested review of this revision.May 23 2025, 5:01 PM
Harbormaster completed remote builds in B64382: Diff 155926.May 23 2025, 5:01 PM
markj added a reviewer: sreekanth.reddy_broadcom.com.May 23 2025, 5:01 PM
markj added a reviewer: imp.May 23 2025, 5:04 PM

I didn't audit other callers of hwrm_send_message() for the same bug, but we should.

zlei added a comment.May 24 2025, 2:17 AM

I do not have any hardware to test this change, but it appear to be a regression by mistake.

Fixes: 050d28e13cde bnxt_en: L2-RoCE driver communication interface

sys/dev/bnxt/bnxt_en/bnxt_hwrm.c
717

This was introduced by 050d28e13cde ( bnxt_en: L2-RoCE driver communication interface ), while the req_len is to support the older/smaller backing_store_cfg message size 2ed061f08d9e ( if_bnxt: Add support for smaller backing_store_cfg message size ).

I think this sizeof(req) is unintentional. Also add Sumit as a review.

zlei added a reviewer: sumit.saxena_broadcom.com.May 24 2025, 2:18 AM
markj added a comment.Sep 11 2025, 12:45 PM

@zlei any objection to simply committing the patch?

zlei accepted this revision.Sep 11 2025, 2:09 PM
In D50491#1198623, @markj wrote:

@zlei any objection to simply committing the patch?

No objections. I think I have read the code carefully, the patch should fix the regression. That ( the regression ) looks much like a copy-paste error.

This revision is now accepted and ready to land.Sep 11 2025, 2:09 PM
Closed by commit rG5ca390f03bc6: bnxt: Fix the request length in bnxt_hwrm_func_backing_store_cfg() (authored by markj). · Explain WhySep 11 2025, 4:08 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG5ca390f03bc6: bnxt: Fix the request length in bnxt_hwrm_func_backing_store_cfg().
markj added a commit: rG20bb3d7d500b: bnxt: Fix the request length in bnxt_hwrm_func_backing_store_cfg().Sun, Sep 21, 2:53 PM
markj added a commit: rG87691082d860: bnxt: Fix the request length in bnxt_hwrm_func_backing_store_cfg().Tue, Sep 30, 3:23 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
bnxt/
bnxt_en/
2 lines

Diff 161906

View Options

sys/dev/bnxt/bnxt_en/bnxt_hwrm.c

Loading...