In D54368#1243166, @markj wrote:

In D54368#1243161, @markj wrote:

I don't understand. This patch is already applied to the tree, commit 35dd53a9e1326.

Oh, it was reverted. It's the same diff as before as far as I can see, just the commit log message changed. It looks like Jessica's main question is, why exactly is it necessary to link libbnxtre:

> Secondly, this states some things, but I don’t see why this change
> follows from it. *Why* does it matter that ibv_devices and rping do not
> link against libbnxtre? If it builds, that means none of libbnxtre’s
> symbols were needed. Is there some magic dynamic registration going on
> in linker sets / constructors inside libbnxtre? Please explain the why
> in the commit message.

Sure enough, a peek at contrib/ofed/libbnxtre/main.c reveals a static __attribute__((constructor)) void bnxt_re_register_driver(void) which registers the driver with libibverbs. So I guess you should mention this mechanism. With that it looks ok to me.