Page MenuHomeFreeBSD
Differential D50461

icmp6: zero out pad space
ClosedPublic
Actions

Authored by kp on May 22 2025, 12:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 21, 3:04 AM
Unknown Object (File)
Sun, Oct 19, 10:14 PM
Unknown Object (File)
Sat, Oct 18, 9:31 PM
Unknown Object (File)
Sat, Sep 27, 12:23 AM
Unknown Object (File)
Sep 19 2025, 12:34 AM
Unknown Object (File)
Sep 17 2025, 11:28 AM
Unknown Object (File)
Sep 12 2025, 3:42 PM
Unknown Object (File)
Sep 2 2025, 8:29 AM
View All 34 Files
Subscribers
ae
glebius
imp
melifaro
zlei

Details

Reviewers
zlei
Group Reviewers
network
pfsense
Commits
rG0a16f62701f1: icmp6: zero out pad space
Summary

In icmp6_redirect_output() we potentially add padding, but failed to clear this
memory. This triggered a KMSAN panic during the sys/netinet/carp:unicast_v6
test.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp created this revision.May 22 2025, 12:39 PM
Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptMay 22 2025, 12:39 PM
kp requested review of this revision.May 22 2025, 12:39 PM
Harbormaster completed remote builds in B64348: Diff 155858.May 22 2025, 12:39 PM
zlei accepted this revision as: zlei.May 22 2025, 2:24 PM
zlei added a subscriber: zlei.

Looks good to me.

This revision is now accepted and ready to land.May 22 2025, 2:24 PM
Closed by commit rG0a16f62701f1: icmp6: zero out pad space (authored by kp). · Explain WhyMay 23 2025, 1:07 PM
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG0a16f62701f1: icmp6: zero out pad space.

Revision Contents
Changeset List

PathSize
sys/
netinet6/
1 line

Diff 155914

View Options

sys/netinet6/icmp6.c

Loading...