ethernet: Set maximum Ethernet header length based on the capability IFCAP_VLAN_MTU
ClosedPublic
Actions

Authored by zlei on Jun 14 2025, 3:22 PM.

Details

Reviewers

kp
markj
glebius

Group Reviewers

network

Commits

rG3bb09e6b1930: ethernet: Set maximum Ethernet header length based on the capability…
rG6ce8fd1978a9: ethernet: Set maximum Ethernet header length based on the capability…

Summary

Lots of Ethernet drivers fix the header length after ether_ifattach().
Well since the net stack can conclude based on the capability
IFCAP_VLAN_MTU, let the net stack do it rather than individual drivers.

MFC after: 2 weeks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei created this revision.Jun 14 2025, 3:22 PM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptJun 14 2025, 3:22 PM

zlei requested review of this revision.Jun 14 2025, 3:22 PM

In-tree drivers will be cleaned up in following up commits. I intended to mention this behavior change in UPDATING, but 3rd party shall not be affected, if they FIX the header length after attaching the interface.

zlei added a subscriber: markj.Jun 14 2025, 4:08 PM

markj accepted this revision as: markj.Jun 16 2025, 1:12 PM

This revision is now accepted and ready to land.Jun 16 2025, 1:12 PM

Definitely an improvement [prolonging life of the current ifapi :) ]

Closed by commit rG6ce8fd1978a9: ethernet: Set maximum Ethernet header length based on the capability… (authored by zlei). · Explain WhySat, Jun 21, 3:28 PM

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rG6ce8fd1978a9: ethernet: Set maximum Ethernet header length based on the capability….

zlei added a commit: rG3bb09e6b1930: ethernet: Set maximum Ethernet header length based on the capability….Mon, Jul 7, 10:09 AM