Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 68104 Build 64987: arc lint + arc unit
Event Timeline
| share/man/man4/dtrace_dtmalloc.4 | ||
|---|---|---|
| 20 | This could go on one line. | |
| share/man/man4/dtrace_dtmalloc.4 | ||
|---|---|---|
| 24 | I think explaining briefly what a malloc "type" is would be useful. | |
| 49 | The probe argument types are already listed by dtrace -lv so I'm not sure it's useful to list them here unless you also describe what they are. Briefly, the first three arguments for each probe provide references to the malloc type internals; size is the size of the allocation; zindx is the index into the kmemzones[] array used for the allocation. In practice, size is the most useful parameter. | |
| 59 | It means that if the malloc type was defined by MALLOC_DEFINE(M_FOO_BAR, "foo bar", "FooBar subsystem"); the probes will be called dtmalloc::foo_bar:. | |
| share/man/man4/dtrace_dtmalloc.4 | ||
|---|---|---|
| 59 | Right, I think it'd be good to make that more explicit. I'm not sure it is immediately obvious. | |
- address feedback (I answered some of the comments directly or at least marked them as done)
- sort copyright header
| share/man/man4/dtrace_dtmalloc.4 | ||
|---|---|---|
| 12 | Plz no xref in titles | |
| 12 | Just to clarify/remove myself as the issue, Xr in Nd does not work with apropos, and probably many other things. When I asked the author of apropos, he said this was not a bug, and changed mdoc(7) to say: "The Nd macro technically accepts child macros and terminates with a subsequent Sh invocation. Do not assume this behaviour: " | |
| share/man/man4/dtrace_dtmalloc.4 | ||
|---|---|---|
| 12 | Yup, thanks for making sure that we do not add more xrefs to titles :) | |