System wide and NUMA domain wide counters support. PMC classes for ARM DMC-620 and CMN-600.
AcceptedPublic
Actions

Authored by ray on Oct 5 2021, 2:51 PM.

Details

Reviewers

mhorne
emaste
andrew
imp

Group Reviewers

pmc

Summary

Add support for system wide and NUMA domain wide counters support.
Add 3 new PMC classes for ARM DMC-620 and CMN-600 controllers PMU.

Sponsored By: ARM
Sponsored By: Ampere Computing

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 41967
Build 38855: arc lint + arc unit

Event Timeline

ray created this revision.Oct 5 2021, 2:51 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 5 2021, 2:51 PM

ray requested review of this revision.Oct 5 2021, 2:51 PM

Harbormaster completed remote builds in B41967: Diff 96274.Oct 5 2021, 2:51 PM

ray edited the summary of this revision. (Show Details)Oct 5 2021, 2:52 PM

ray added reviewers: pmc, mhorne.

allanjude added a subscriber: allanjude.Oct 5 2021, 3:25 PM

ray added reviewers: emaste, andrew.Oct 6 2021, 12:33 PM

allanjude edited the summary of this revision. (Show Details)Oct 20 2021, 11:40 PM

If I understand this right, this looks good to my eye. It adds all the right things in the right places, but I'm not a domain expert.

This revision is now accepted and ready to land.Dec 23 2021, 3:17 PM

So, the main challenge here is that checking the caps of an event requires allocating it earlier than usual? I think its unfortunate to have to add this code to the option parsing, but I don't see a better alternative.

sys/sys/pmc.h
310–311	These will need descriptions in `pmc(3)`.
usr.sbin/pmcstat/pmcstat.c
119	this could be a bool
768	Perhaps it should set `args.pa_flags \|= FLAGS_HAS_CPUMASK` here as well? I think there is no functional impact, but is accurate.