Details

Reviewers

mhorne
emaste
andrew
ray
pauamma_gundo.com

Group Reviewers

manpages
pmc

Commits

rGda4e1e319c6c: Add the Arm CoreLink CMN-600 Coherent Mesh Network Controller PMU driver man…

Summary

Add the Arm CoreLink CMN-600 Coherent Mesh Network Controller PMU driver man page.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ray created this revision.Oct 6 2021, 9:28 AM

Herald added a reviewer: manpages. · View Herald TranscriptOct 6 2021, 9:28 AM

Herald added a subscriber: imp. · View Herald Transcript

ray requested review of this revision.Oct 6 2021, 9:28 AM

Harbormaster completed remote builds in B41982: Diff 96336.Oct 6 2021, 9:28 AM

ray edited the summary of this revision. (Show Details)Oct 6 2021, 11:37 AM

ray added reviewers: pmc, mhorne.

ray added reviewers: emaste, andrew.Oct 6 2021, 12:35 PM

allanjude edited the summary of this revision. (Show Details)Oct 20 2021, 11:39 PM

Could you ran 'mandoc -Tlint' over the man page. There are plenty of warnings, which could easily be fixed, like 'new sentence, new line' and so on. It would be nice if you could also add the author of the man page.

And you have to include this man page in the makefile of the directory.

Fix formating according to mandoc lint hints.

Harbormaster completed remote builds in B43476: Diff 100292.Dec 19 2021, 3:18 PM

In D32335#747099, @gbe wrote:

Could you ran 'mandoc -Tlint' over the man page. There are plenty of warnings, which could easily be fixed, like 'new sentence, new line' and so on. It would be nice if you could also add the author of the man page.

And you have to include this man page in the makefile of the directory.

Done. Thanks for review, Gordon!

Most of the content is beyond me, but still have a few suggestions.

lib/libpmc/pmc.cmn-600.3
42	The capitalisation of "Id" here looks odd to me, but it may just be me. (In case it's not, I'd use either "ID" or "identifier".)
44–54	Worth using Bl/El/It here for clarity?
176	Spurious space after "-"? Also, does the intended audience for this know what "protocol-retried" means?
272
596	Maybe include the manual page author as well, as shown in the vt(4) example in https://docs.freebsd.org/en/books/fdp-primer/manual-pages/#manual-pages-examples-as-templates ?