Page MenuHomeFreeBSD

xinstall: Const correctness for C23
ClosedPublic

Authored by ivy on Mon, Jul 27, 10:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Aug 23, 6:11 PM
Unknown Object (File)
Sun, Aug 23, 3:03 AM
Unknown Object (File)
Thu, Aug 20, 11:19 PM
Unknown Object (File)
Wed, Aug 19, 6:34 PM
Unknown Object (File)
Thu, Aug 13, 3:09 AM
Unknown Object (File)
Wed, Aug 12, 8:34 AM
Unknown Object (File)
Sun, Aug 9, 3:35 AM
Unknown Object (File)
Sat, Aug 8, 10:49 AM
Subscribers

Details

Summary

On some platforms, e.g. Linux Clang 22.1.8 / glibc 2.43, strchr()
now implements the C23 behaviour where passing a const pointer to
strchr() also returns a const pointer. This breaks xinstall during
the bootstrap build, since it assumes the return value is always
a mutable pointer.

As the returned pointer is never used to modify the value, fix this
by making the temporary variable const.

MFC after: 1 week
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable