Page MenuHomeFreeBSD

Add pmc.dmc-620(3) man page.
ClosedPublic

Authored by tsoome on Oct 26 2021, 12:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 30, 6:43 AM
Unknown Object (File)
Wed, Mar 27, 9:14 AM
Unknown Object (File)
Mon, Mar 25, 5:08 AM
Unknown Object (File)
Mon, Mar 25, 1:19 AM
Unknown Object (File)
Fri, Mar 22, 12:29 AM
Unknown Object (File)
Wed, Mar 20, 1:51 AM
Unknown Object (File)
Sun, Mar 17, 6:07 PM
Unknown Object (File)
Mar 8 2024, 7:48 AM

Details

Summary

Add pmc.dmc-620(3) man page.

Sponsored By: Ampere Computing

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ray requested review of this revision.Oct 26 2021, 12:52 PM

Seems fine so far with a few minor issues, but you must add the man page to the makefile to install it.

lib/libpmc/pmc.dmc-620.3
27

Please bump before committing the man page.

54

Can be removed since .Ss is also a new paragraph.

166

Please add the author of the man page.

pauamma_gundo.com added inline comments.
lib/libpmc/pmc.dmc-620.3
25

Is the "$FreeBSD$" boilerplate still needed following the git conversion? https://docs.freebsd.org/en/books/fdp-primer/translations/#_can_i_include_language_or_country_specific_text_in_my_translation (8.10.2) points to either "yes" or "that part of the documentation didn't get updated at the time", but I don't know which offhand0

lib/libpmc/pmc.dmc-620.3
25

If this might be MFCd to 12, thennleave it in. Otherwise don't bother.

ray marked 3 inline comments as done.Dec 19 2021, 12:44 PM

Fixed. Thanks for review!

lib/libpmc/pmc.dmc-620.3
25

Not sure about MFCing. So will leave it yet.

tsoome added a reviewer: ray.

Do not split authors on new lines.

pauamma_gundo.com added inline comments.
lib/libpmc/pmc.dmc-620.3
2

Or 2021-2022 as applicable.

76

Either "Two bits that control" or "Two-bit value that controls" (I think the latter).

77

US spelling

90–93

Is that either/or, or a single prefix combining both? If the former, use that instead of "and". If the latter, give the combined prefix explicitly. Either way, consider s/are named using/use/.

95
164–165
166

Please add the author of the man page.

Seconded. (I don't see it.)

This revision now requires changes to proceed.Jul 22 2022, 11:11 AM
lib/libpmc/pmc.dmc-620.3
2

Does it need All rights reserved?

tsoome marked 7 inline comments as done.

suggestions from review.

update date and nuke $FreeBSD$

English LGTM as long as the content matches reality.

This revision is now accepted and ready to land.Jul 26 2022, 3:45 AM
This revision was automatically updated to reflect the committed changes.