Page MenuHomeFreeBSD
Differential D32320

Allocate event for DMC-620 and CMN-600 controllers PMU. Add events supported by DMC-620 and CMN-600 controllers PMU.
Needs ReviewPublic
Actions

Authored by ray on Oct 5 2021, 3:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 3:05 AM
Unknown Object (File)
Sat, Jan 18, 5:22 PM
Unknown Object (File)
Dec 20 2024, 4:32 PM
Unknown Object (File)
Dec 14 2024, 11:48 AM
Unknown Object (File)
Dec 4 2024, 6:09 PM
Unknown Object (File)
Dec 4 2024, 7:24 AM
Unknown Object (File)
Dec 4 2024, 7:24 AM
Unknown Object (File)
Dec 4 2024, 7:03 AM
View All 32 Files
Subscribers
allanjude
andrew
emaste
imp

Details

Reviewers
manu
mhorne
Group Reviewers
pmc
Summary

Allocate event for DMC-620 and CMN-600 controllers PMU.
Add events supported by DMC-620 and CMN-600 controllers PMU.

Sponsored By: ARM
Sponsored By: Ampere Computing

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 41968
Build 38856: arc lint + arc unit

Event Timeline

ray created this revision.Oct 5 2021, 3:04 PM
Herald added a reviewer: manu. · View Herald TranscriptOct 5 2021, 3:04 PM
Herald added subscribers: emaste, andrew, imp. · View Herald Transcript
ray requested review of this revision.Oct 5 2021, 3:04 PM
Harbormaster completed remote builds in B41968: Diff 96275.Oct 5 2021, 3:04 PM
ray edited the summary of this revision. (Show Details)Oct 5 2021, 3:06 PM
ray added reviewers: pmc, mhorne.
allanjude added a subscriber: allanjude.Oct 5 2021, 3:25 PM
mhorne added a comment.Oct 13 2021, 7:29 PM

Is there a review for a dmc620 driver still to come?

lib/libpmc/libpmc.c
1370

Missing break?

sys/arm64/include/cmn600_reg.h
30–31
sys/dev/hwpmc/pmc_events.h
2065–2067

Is there a possibility that future revisions of this hw will add more events to any of these lists? Should these ranges be spaced out further to accommodate this?

sys/dev/hwpmc/pmu_dmc620_reg.h
77–81

This struct should go in sys/dev/hwpmc/hwpmc_dmc620.h.

allanjude edited the summary of this revision. (Show Details)Oct 20 2021, 11:39 PM
tsoome mentioned this in D35609: Allocate event for DMC-620 and CMN-600 controllers PMU. Add events supported by DMC-620 and CMN-600 controllers PMU..Jun 26 2022, 8:38 PM

Revision Contents
Changeset List

PathSize
lib/
libpmc/
180 lines
sys/
arm64/
include/
793 lines
24 lines
dev/
hwpmc/
54 lines
44 lines
241 lines
94 lines

Diff 96275

View Options

lib/libpmc/libpmc.c

Loading...
View Options

sys/arm64/include/cmn600_reg.h

Loading...
View Options

sys/arm64/include/pmc_mdep.h

Loading...
View Options

sys/dev/hwpmc/hwpmc_cmn600.h

Loading...
View Options

sys/dev/hwpmc/hwpmc_dmc620.h

Loading...
View Options

sys/dev/hwpmc/pmc_events.h

Loading...
View Options

sys/dev/hwpmc/pmu_dmc620_reg.h

Loading...