Page MenuHomeFreeBSD
Differential D45577

amd64 pmap: Release PTP reference on leaf ptpage allocation failure
ClosedPublic
Actions

Authored by bnovkov on Thu, Jun 13, 4:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 16, 7:53 PM
Unknown Object (File)
Sun, Jun 16, 4:59 AM
Unknown Object (File)
Sat, Jun 15, 6:01 PM
Subscribers
imp

Details

Reviewers
markj
alc
kib
Commits
rGb53b21e8f81a: amd64 pmap: Release PTP reference on leaf ptpage allocation failure
Summary

aa3bcaa fixed an edge case invloving mlock() and superpage creation
by creating and inserting a leaf pagetable page for mlock'd superpages.
However, the code does not properly release the reference to the
pagetable page in the error handling path.
This commit fixes the issue by adding calls to 'pmap_abort_ptp'
in the error handling path.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bnovkov created this revision.Thu, Jun 13, 4:27 PM
Herald added a subscriber: imp. · View Herald TranscriptThu, Jun 13, 4:27 PM
bnovkov requested review of this revision.Thu, Jun 13, 4:27 PM
Harbormaster completed remote builds in B58165: Diff 139806.Thu, Jun 13, 4:27 PM
bnovkov edited the summary of this revision. (Show Details)Thu, Jun 13, 4:27 PM
alc accepted this revision.Thu, Jun 13, 7:35 PM
This revision is now accepted and ready to land.Thu, Jun 13, 7:35 PM
kib accepted this revision.Thu, Jun 13, 7:41 PM
markj accepted this revision.Fri, Jun 14, 1:54 PM
markj added inline comments.Fri, Jun 14, 2:00 PM
sys/amd64/amd64/pmap.c
7599

There are some code paths in this function which handle pdpg == NULL, but I don't think that's possible.

alc added inline comments.Fri, Jun 14, 11:03 PM
sys/amd64/amd64/pmap.c
7599

Yes, because pmap != kernel_pmap.

Closed by commit rGb53b21e8f81a: amd64 pmap: Release PTP reference on leaf ptpage allocation failure (authored by bnovkov). · Explain WhySun, Jun 16, 4:21 PM
This revision was automatically updated to reflect the committed changes.
bnovkov added a commit: rGb53b21e8f81a: amd64 pmap: Release PTP reference on leaf ptpage allocation failure.

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
5 lines

Diff 139891

View Options

sys/amd64/amd64/pmap.c

Loading...